Skip to content

fix: better paste handling #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 20, 2024
Merged

fix: better paste handling #1324

merged 12 commits into from
Dec 20, 2024

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Dec 14, 2024

TODO:

  • fix build
  • add unit tests for (a) pasting tables (b) 1198 (c) pasting inside a custom block

Copy link

vercel bot commented Dec 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Dec 20, 2024 1:02pm
blocknote-website ✅ Ready (Inspect) Visit Preview Dec 20, 2024 1:02pm

Copy link
Collaborator Author

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments. Did you also check the tests without the code changes? (i.e.: validated whether the tests are indeed going from "wrong snapshot" to "correct snapshot" when enabling the fixes)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy pasting an Emoji insert a page break Pasting text pastes it inside a new block
2 participants