Skip to content

feat: Added parameter for updating custom inline content in render #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

matthewlipski
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Sep 16, 2024 5:12pm
blocknote-website ✅ Ready (Inspect) Visit Preview Sep 16, 2024 5:12pm

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this looks good. Have you been able to test:

  • the new method
  • whether vanilla (non-react) IC still works as expected?

Maybe discuss if there's an easy way to unit test this

@matthewlipski
Copy link
Collaborator Author

imo this looks good. Have you been able to test:

  • the new method
  • whether vanilla (non-react) IC still works as expected?

Maybe discuss if there's an easy way to unit test this

Can confirm that everything works as expected for both vanilla and React blocks. Tested by adding an click listener to the existing mentions IC examples which calls the update function.

@matthewlipski matthewlipski merged commit 9a741d7 into main Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants