-
-
Notifications
You must be signed in to change notification settings - Fork 558
fix: Loading indicator when dropping/pasting files #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a loading
prop is suitable for this. For example:
- It will mean the "loading" value will be part of the (stored) document and stored in the db
- it will conflict with history (undo / redo, etc)
we'll need to brainstorm a different architecture
Do you have anything in mind? I was thinking we could expose an |
This PR adds a
loading
prop to the default file blocks, which causes them to render aLoading...
indicator whentrue
. Unfortunately, the delay is happening ineditor.uploadFile
, which is not really related to the block itself. So that means we don't have an existing way of checking if a file is being uploaded while the block is rendered.