fix: Block insert twice when using korean at suggestion #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@d2n0s4ur is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any languages with composition sessions (Korean, Japanese, etc..) have
isComposingat keydown events.Because of this, using the Korean suggestion make two same blocks(ex. /이미지, /구분선).
(If you press Enter after typing Korean, the keyDown event is fired both when the isComposing state is true and when it is false, resulting in two blocks with duplicate events.)
to prevent this situation, checking
event.isComposingis necessary.by simply adding checking
event.isCompoising == false, We can prevent making blocks twice when using Korean.here is the MDN page that explains
isComposinghttps://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/isComposing