Skip to content

Conversation

@qianlongzt
Copy link

@qianlongzt qianlongzt commented Oct 22, 2025

Summary

  1. fix Run Domain Expiration checks on the root domain #1159
image image
  1. Refactor Type for simplification and better performance
  2. add missing endpoint type test for grpc feat(client): Add support for monitoring gRPC endpoints #1376

test result for perfomance

cpu: AMD Ryzen 7 4800H with Radeon Graphics
BenchmarkEndpoint_Type-16

Cut + switch 5053628 238.7 ns/op 0 B/op 0 allocs/op
Cut + map 2714998 438.6 ns/op 0 B/op 0 allocs/op
switch HasPerfix 2683519 430.9 ns/op 0 B/op 0 allocs/op

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@github-actions github-actions bot added the feature New feature or request label Oct 22, 2025
@qianlongzt
Copy link
Author

@TwiN Is there anything I can do to help merge PR? Is there no progress?

test result

cpu: AMD Ryzen 7 4800H with Radeon Graphics
BenchmarkEndpoint_Type-16

Cut + switch     5053628 238.7 ns/op 0 B/op 0 allocs/op
Cut + map        2714998 438.6 ns/op 0 B/op 0 allocs/op
switch HasPerfix 2683519 430.9 ns/op 0 B/op 0 allocs/op
@qianlongzt
Copy link
Author

@PythonGermany Your PR qianlongzt#1 looks good to me, but what should I do next?

  1. Merge your PR first and then wait for @TwiN to review?
  2. Or should I not merge it, and instead have you submit your PR to @TwiN after my PR is merged?

@PythonGermany
Copy link
Contributor

@qianlongzt Just merge my changes into your branch.

// domain expiration checked before call `call`
return
case TypeHTTP:
request = e.buildHTTPRequest()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed my previous refactoring introduces one unintended (and maybe unwanted change). The startTime is now set before starting to build the http request.

To restore the original behavior we should update the startTime after building the request:

Suggested change
request = e.buildHTTPRequest()
request = e.buildHTTPRequest()
startTime = time.Now()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Domain Expiration checks on the root domain

2 participants