Allow additional terminating properties to be configured #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whamondg
changed the title
Turbo87
reviewed
Oct 10, 2017
| @@ -50,5 +50,18 @@ ruleTester.run('terminating-properties', rule, { | |||
| errors: [{ | |||
| message: '"to.exist" used as function' | |||
| }] | |||
| }, { | |||
| options: [{terminators:['something', 'somethingElse']}], | |||
There was a problem hiding this comment.
could you change the name of that option to properties instead? that would match what I proposed in #20
There was a problem hiding this comment.
I have done that, what do you think?
|
nice work, thanks @whamondg! |
|
I just noticed that we haven't documented the option though. Could you maybe work on a follow-up PR that adds a few words about the new option to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18