Fix leak in complete() callback of Database.each() #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add destructor to EachBaton that disposes the `completed` callback function.
|
Thank you! |
|
Was able to replicate and confirm this fixes - great work, will push out release next so that this will be included in the upcoming |
springmeyer
pushed a commit
that referenced
this pull request
Aug 6, 2014
Fix leak in complete() callback of Database.each()
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add destructor to EachBaton that disposes the
completedcallback function.Fixes #297.
I didn't implement the part of my previous patch that prevented the duplication of the callback handles in
Statement::Work_BeginEachbecause 1. it's not strictly necessary and 2. I don't understand enough of this nan stuff to be confident to do it right.I've checked (using node v0.10.22) that 1. the memory leak still exists in current HEAD and 2. this patch fixes it.