Building 2.2.3 with node-webkit@0.9.2 fails on MacOSX 10.9.2

[keithamus]

$ npm install sqlite3@2.2.3 --save --build-from-source --runtime=node-webkit --target_arch=ia32 --target=0.9.2
npm WARN package.json demo@0.1.0 No description
npm WARN package.json demo@0.1.0 No repository field.
npm WARN package.json demo@0.1.0 No README data
npm http GET https://registry.npmjs.org/sqlite3/2.2.3
npm http 304 https://registry.npmjs.org/sqlite3/2.2.3
npm http GET https://registry.npmjs.org/sqlite3/-/sqlite3-2.2.3.tgz
npm http 200 https://registry.npmjs.org/sqlite3/-/sqlite3-2.2.3.tgz

> sqlite3@2.2.3 install /Users/keith/Projects/nwsqlitedemo/node_modules/sqlite3
> node-pre-gyp install --fallback-to-build

  ACTION deps_sqlite3_gyp_action_before_build_target_unpack_sqlite_dep Release/obj/gen/sqlite-autoconf-3080403/sqlite3.c
  TOUCH Release/obj.target/deps/action_before_build.stamp
  CC(target) Release/obj.target/sqlite3/gen/sqlite-autoconf-3080403/sqlite3.o
Release/obj/gen/sqlite-autoconf-3080403/sqlite3.c:8445:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
SQLITE_PRIVATE const int sqlite3one = 1;
                         ^
1 warning generated.
  LIBTOOL-STATIC Release/sqlite3.a
  CXX(target) Release/obj.target/node_sqlite3/src/database.o
In file included from ../src/database.cc:5:
../src/database.h:20:25: error: expected class name
class Database : public ObjectWrap {
                        ^
../src/database.h:125:62: error: unknown type name 'AccessorInfo'
    static Handle<Value> OpenGetter(Local<String> str, const AccessorInfo& accessor);
                                                             ^
../src/database.h:40:17: error: no member named 'Ref' in 'node_sqlite3::Database'
            db->Ref();
            ~~  ^
../src/database.h:45:17: error: no member named 'Unref' in 'node_sqlite3::Database'
            db->Unref();
            ~~  ^
../src/database.h:101:18: error: member initializer 'ObjectWrap' does not name a non-static data member or base class
    Database() : ObjectWrap(),
                 ^~~~~~~~~~~~
In file included from ../src/database.cc:6:
../src/statement.h:74:26: error: expected class name
class Statement : public ObjectWrap {
                         ^
../src/statement.h:88:19: error: no member named 'Ref' in 'node_sqlite3::Statement'
            stmt->Ref();
            ~~~~  ^
../src/statement.h:97:19: error: no member named 'Unref' in 'node_sqlite3::Statement'
            stmt->Unref();
            ~~~~  ^
../src/statement.h:135:19: error: no member named 'Ref' in 'node_sqlite3::Statement'
            stmt->Ref();
            ~~~~  ^
../src/statement.h:138:19: error: no member named 'Unref' in 'node_sqlite3::Statement'
            stmt->Unref();
            ~~~~  ^
../src/statement.h:172:19: error: no member named 'Ref' in 'node_sqlite3::Statement'
            stmt->Ref();
            ~~~~  ^
../src/statement.h:177:19: error: no member named 'Unref' in 'node_sqlite3::Statement'
            stmt->Unref();
            ~~~~  ^
../src/statement.h:184:32: error: member initializer 'ObjectWrap' does not name a non-static data member or base class
    Statement(Database* db_) : ObjectWrap(),
                               ^~~~~~~~~~~~
../src/statement.h:191:13: error: no member named 'Ref' in 'node_sqlite3::Database'
        db->Ref();
        ~~  ^
../src/database.cc:15:55: error: cannot initialize a parameter of type 'FunctionCallback' (aka 'void (*)(const
      FunctionCallbackInfo<v8::Value> &)') with an lvalue of type 'Handle<v8::Value> (const v8::Arguments &)': type mismatch at 1st
      parameter ('const FunctionCallbackInfo<v8::Value> &' vs 'const v8::Arguments &')
    Local<FunctionTemplate> t = FunctionTemplate::New(New);
                                                      ^~~
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:3379:24: note: passing argument to parameter 'callback' here
      FunctionCallback callback = 0,
                       ^
../src/database.cc:21:31: error: no viable conversion from 'Persistent<v8::FunctionTemplate>' to 'v8::Handle<v8::FunctionTemplate>'
    NODE_SET_PROTOTYPE_METHOD(constructor_template, "close", Close);
                              ^~~~~~~~~~~~~~~~~~~~
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:211:26: note: candidate constructor (the implicit copy constructor) not viable: no
      known conversion from 'Persistent<v8::FunctionTemplate>' to 'const v8::Handle<v8::FunctionTemplate> &' for 1st argument
template <class T> class Handle {
                         ^
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:228:32: note: candidate template ignored: could not match 'Handle' against 'Persistent'
  template <class S> V8_INLINE Handle(Handle<S> that)
                               ^
/Users/keith/.nw-gyp/0.9.2/src/node.h:185:72: note: passing argument to parameter 'recv' here
inline void NODE_SET_PROTOTYPE_METHOD(v8::Handle<v8::FunctionTemplate> recv,
                                                                       ^
../src/database.cc:22:31: error: no viable conversion from 'Persistent<v8::FunctionTemplate>' to 'v8::Handle<v8::FunctionTemplate>'
    NODE_SET_PROTOTYPE_METHOD(constructor_template, "exec", Exec);
                              ^~~~~~~~~~~~~~~~~~~~
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:211:26: note: candidate constructor (the implicit copy constructor) not viable: no
      known conversion from 'Persistent<v8::FunctionTemplate>' to 'const v8::Handle<v8::FunctionTemplate> &' for 1st argument
template <class T> class Handle {
                         ^
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:228:32: note: candidate template ignored: could not match 'Handle' against 'Persistent'
  template <class S> V8_INLINE Handle(Handle<S> that)
                               ^
/Users/keith/.nw-gyp/0.9.2/src/node.h:185:72: note: passing argument to parameter 'recv' here
inline void NODE_SET_PROTOTYPE_METHOD(v8::Handle<v8::FunctionTemplate> recv,
                                                                       ^
../src/database.cc:23:31: error: no viable conversion from 'Persistent<v8::FunctionTemplate>' to 'v8::Handle<v8::FunctionTemplate>'
    NODE_SET_PROTOTYPE_METHOD(constructor_template, "wait", Wait);
                              ^~~~~~~~~~~~~~~~~~~~
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:211:26: note: candidate constructor (the implicit copy constructor) not viable: no
      known conversion from 'Persistent<v8::FunctionTemplate>' to 'const v8::Handle<v8::FunctionTemplate> &' for 1st argument
template <class T> class Handle {
                         ^
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:228:32: note: candidate template ignored: could not match 'Handle' against 'Persistent'
  template <class S> V8_INLINE Handle(Handle<S> that)
                               ^
/Users/keith/.nw-gyp/0.9.2/src/node.h:185:72: note: passing argument to parameter 'recv' here
inline void NODE_SET_PROTOTYPE_METHOD(v8::Handle<v8::FunctionTemplate> recv,
                                                                       ^
../src/database.cc:24:31: error: no viable conversion from 'Persistent<v8::FunctionTemplate>' to 'v8::Handle<v8::FunctionTemplate>'
    NODE_SET_PROTOTYPE_METHOD(constructor_template, "loadExtension", LoadExtension);
                              ^~~~~~~~~~~~~~~~~~~~
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:211:26: note: candidate constructor (the implicit copy constructor) not viable: no
      known conversion from 'Persistent<v8::FunctionTemplate>' to 'const v8::Handle<v8::FunctionTemplate> &' for 1st argument
template <class T> class Handle {
                         ^
/Users/keith/.nw-gyp/0.9.2/deps/v8/include/v8.h:228:32: note: candidate template ignored: could not match 'Handle' against 'Persistent'
  template <class S> V8_INLINE Handle(Handle<S> that)
                               ^
/Users/keith/.nw-gyp/0.9.2/src/node.h:185:72: note: passing argument to parameter 'recv' here
inline void NODE_SET_PROTOTYPE_METHOD(v8::Handle<v8::FunctionTemplate> recv,
                                                                       ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Release/obj.target/node_sqlite3/src/database.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/share/npm/lib/node_modules/nw-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:797:12)
gyp ERR! System Darwin 13.1.0
gyp ERR! command "node" "/usr/local/share/npm/bin/nw-gyp" "rebuild" "--name=sqlite3" "--configuration=Release" "--module_name=node_sqlite3" "--version=2.2.3" "--major=2" "--minor=2" "--patch=3" "--runtime=node-webkit" "--node_abi=node-webkit-v13" "--target=0.9.2" "--platform=darwin" "--arch=ia32" "--target_arch=ia32" "--module_main=./lib/sqlite3" "--host=https://node-sqlite3.s3.amazonaws.com/" "--module_path=/Users/keith/Projects/nwsqlitedemo/node_modules/sqlite3/lib/binding/node-webkit-v13-darwin-ia32" "--remote_path=./Release/" "--package_name=node_sqlite3-v2.2.3-node-webkit-v13-darwin-ia32.tar.gz" "--staged_tarball=build/stage/Release/node_sqlite3-v2.2.3-node-webkit-v13-darwin-ia32.tar.gz" "--hosted_path=https://node-sqlite3.s3.amazonaws.com/Release/" "--hosted_tarball=https://node-sqlite3.s3.amazonaws.com/Release/node_sqlite3-v2.2.3-node-webkit-v13-darwin-ia32.tar.gz"
gyp ERR! cwd /Users/keith/Projects/nwsqlitedemo/node_modules/sqlite3
gyp ERR! node -v v0.10.26
gyp ERR! nw-gyp -v v0.12.2
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute 'nw-gyp rebuild --name=sqlite3 --configuration=Release --module_name=node_sqlite3 --version=2.2.3 --major=2 --minor=2 --patch=3 --runtime=node-webkit --node_abi=node-webkit-v13 --target=0.9.2 --platform=darwin --arch=ia32 --target_arch=ia32 --module_main=./lib/sqlite3 --host=https://node-sqlite3.s3.amazonaws.com/ --module_path=/Users/keith/Projects/nwsqlitedemo/node_modules/sqlite3/lib/binding/node-webkit-v13-darwin-ia32 --remote_path=./Release/ --package_name=node_sqlite3-v2.2.3-node-webkit-v13-darwin-ia32.tar.gz --staged_tarball=build/stage/Release/node_sqlite3-v2.2.3-node-webkit-v13-darwin-ia32.tar.gz --hosted_path=https://node-sqlite3.s3.amazonaws.com/Release/ --hosted_tarball=https://node-sqlite3.s3.amazonaws.com/Release/node_sqlite3-v2.2.3-node-webkit-v13-darwin-ia32.tar.gz' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/keith/Projects/nwsqlitedemo/node_modules/sqlite3/node_modules/node-pre-gyp/lib/util/compile.js:76:29)
node-pre-gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
node-pre-gyp ERR! stack     at maybeClose (child_process.js:743:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:810:5)
node-pre-gyp ERR! System Darwin 13.1.0
node-pre-gyp ERR! command "node" "/Users/keith/Projects/nwsqlitedemo/node_modules/sqlite3/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/keith/Projects/nwsqlitedemo/node_modules/sqlite3
node-pre-gyp ERR! node -v v0.10.26
node-pre-gyp ERR! node-pre-gyp -v v0.5.9
node-pre-gyp ERR! not ok
npm ERR! sqlite3@2.2.3 install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the sqlite3@2.2.3 install script.
npm ERR! This is most likely a problem with the sqlite3 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get their info via:
npm ERR!     npm owner ls sqlite3
npm ERR! There is likely additional logging output above.

npm ERR! System Darwin 13.1.0
npm ERR! command "/usr/local/Cellar/node/0.10.26/bin/node" "/usr/local/bin/npm" "install" "sqlite3@2.2.3" "--save" "--build-from-source" "--runtime=node-webkit" "--target_arch=ia32" "--target=0.9.2"
npm ERR! cwd /Users/keith/Projects/nwsqlitedemo
npm ERR! node -v v0.10.26
npm ERR! npm -v 1.4.3
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/keith/Projects/nwsqlitedemo/npm-debug.log
npm ERR! not ok code 0

[springmeyer]

This is because node-sqlite3 does not quite yet support node v0.11.x (which is what node-webkit 0.9.x uses). So, stick with node-webkit 0.8.x and you'll be okay or build this branch: #184

[dimsuz]

The branch #184 got merged, but as I see it is not possible to build node-sqlite3 against node-webkit 0.9.x, because it is based on Node v0.11.9, while node-sqlite3 >= 2.2.4-alpha supports only node versions above 0.11.13.

Now there's a node-webkit v0.10.0-rc1 which is based on node-0.11.13, so it should theoretically work, but when being built from source node-sqlite3-2.2.4-alpha complains that this version of node-webkit is not supported (not listed in nw_crosswalk.json).

Is this support planned for near future? Is it ok to create the issue for this, or is it too early and better to wait for nw-0.10.0 release?

[springmeyer]

@dimsuz thanks for testing. The nw_crosswalk issue is solved in mapbox/node-pre-gyp#91 so just force update your node-pre-gyp until I can get another release out.

[Mithgol]

@springmeyer The changes in mapbox/node-pre-gyp#91 do not seem to contain anything about node-webkit v0.10.0-rc1 and thus another patch seems necessary, such as mapbox/node-pre-gyp#92 for example.

[Mithgol]

For future references (such as that one): the experimental node-webkit's branch v0.9.x is not supported by the sqlite3 module.

Therefore, if you need to use the sqlite3 module in some node-webkit's version newer than v0.8.x, pick node-webkit v0.10.x.