ObjectWrap->handle_ private in node master

[feichh]

Hi,
I'm not a very experienced C++ developer, but I am trying to compile node-sqlite3 against the current node master.
I noticed that nodejs/node-v0.x-archive@110a9cd made ObjectWrap->handle_ private and replaced it with two methods handle() and handle(Isolate) ?

• v8::Persistent no longer derives from v8::Handle and no longer
  allows you to directly dereference the object that the persistent
  handle points to. This means that the common pattern of caching
  oft-used JS values in a persistent handle no longer quite works,
  you first need to reconstruct a v8::Local from the persistent
  handle with the Local::New(isolate, persistent) factory method.

it appears Database->handle overshadows this?
subsequently all calls to handle_ in database.cc produce compile time errors.
Is there a way to work around this, or do you have to rename Database->handle into handle_ and change all the calls accordingly?

cheers

[springmeyer]

The API changes were significant and require a lot more than just changing the handle_ access. I'm planning on waiting until v0.12.x is released to start adapting to the new API because I don't want to loose time chasing further API changes.

So, I don't recommend you use node trunk with node-sqlite3.

[feichh]

OK,
I'll try again with a v0.10 branch. thanks for your quick response.

cheers

[springmeyer]

closing, tracking at #180