Skip to content

Conversation

@Tochemey
Copy link
Owner

@Tochemey Tochemey commented Nov 16, 2025

  • Refactor Passivation engine
  • Refactor PID struct by trimming it a bit

closes #977

@Tochemey Tochemey added the performance Performance improvement label Nov 16, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

❌ Patch coverage is 94.59963% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.70%. Comparing base (eff8ff4) to head (ffb1b71).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
actor/passivation_manager.go 92.65% 14 Missing and 9 partials ⚠️
actor/pid.go 94.23% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   93.82%   93.70%   -0.13%     
==========================================
  Files         134      136       +2     
  Lines       10434    10813     +379     
==========================================
+ Hits         9790    10132     +342     
- Misses        412      437      +25     
- Partials      232      244      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tochemey Tochemey changed the title perf: ⚡ refactor pid to reduce memory foot-print perf: ⚡ refactor grain/pid to reduce memory foot-print Nov 16, 2025
@Tochemey Tochemey merged commit 9d467c1 into main Nov 17, 2025
7 checks passed
@Tochemey Tochemey deleted the issue-perf branch November 17, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: reduce memory foot-print for PID

2 participants