Allow a GeoJSON collection's name to be set in write mode #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
commented
Mar 11, 2024
| driver="GeoJSON", | ||
| crs="EPSG:4326", | ||
| schema={"geometry": "Point", "properties": {"foo": "int"}}, | ||
| layer="Darwin Núñez", |
Member
Author
There was a problem hiding this comment.
I want to be sure that we support Unicode layer names 😆 ⚽ 🇺🇾 🟥
sgillies
commented
Mar 11, 2024
|
|
||
| @pytest.mark.skipif( | ||
| sys.platform == "win32", | ||
| reason="Windows test runners don't have full unicode support", |
Member
Author
There was a problem hiding this comment.
We'll figure this out later. Some lack of libiconv or configuration thereof, I bet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1351