Implemented a way to get a valid x-client-transaction-id header for requests #64

Teskann · 2025-07-13T14:25:17Z

Adressed #58

Issue was a missing header in the X graphql requests: x-client-transaction-id
This ID is supposed to be generated. As the generation is quite complex, I decided to rely on an existing working implementation: https://github.com/iSarabjitDhiman/XClientTransaction

This implementation is in Python but is very light weight. This is why I created a flask webserver that runs iSarabjitDhiman/XClientTransaction.

The project wrapping it to flask is available here: https://github.com/Teskann/x-client-transaction-id-generator

I created a public instance of this server on https://x-client-transaction-id-generator.xyz/

The idea in Quacker is to ask this server to generate an x-client-transaction-id for us. As this operation is very fast, I don't think it's an issue to contact another server.

I added an option to change the URL of the provider so that users can use any other working instance, maybe their own.

Regarding the code:

I moved the headers management to a separate class
I moved some functions from client_regular_account to accounts.dart / headers.dart
I added the option to change the provider of xclient-transaction-id in General settings
To manage the translation, I saw that the generated files are committed so I included them as well, because I didn't know if I should. I added a translation to french as it's my mother language.

Teskann · 2025-07-13T14:25:57Z

lib/client/accounts.dart

@@ -0,0 +1,6 @@
+import 'package:quacker/database/repository.dart';


This was moved from client_regular_account.dart

…equests

Teskann · 2025-07-13T15:02:08Z

I finally decided to remove the generated files from the commit to ease the review :) Tell me if you really need these for the release

Teskann · 2025-07-13T23:11:27Z

Please find the build here if you want to test this fix: https://github.com/Teskann/Quacker/releases/tag/untagged-44319a22a7b1fab4581e

(I kept the same package name that I signed with my own key)

TheHCJ · 2025-07-14T07:47:33Z

Your a lifesaver, I'll take a look at the code later today :)

Teskann · 2025-07-14T08:39:22Z

lib/client/client.dart


    if (authHeader != null) {
-      return await model.fetch(uri, headers: headers, log: log, prefs: prefs, authHeader: authHeader);


prefs was unused, so I removed it

Teskann · 2025-07-14T08:42:25Z

lib/client/client_regular_account.dart

-      'authorization': bearerToken,
-      'x-twitter-active-user': 'yes',
-      'user-agent': userAgentHeader.toString()
+      ...baseHeaders


baseHeaders now contains everything that was here before so it can safely replace what was previously declared. It will include more headers than before however. Tell me if this is a problem. See headers.dart for more info

Teskann · 2025-07-14T08:42:53Z

lib/client/client_regular_account.dart

    });

    return response;
  }

-  Future<List<Map<String, Object?>>> getAccounts() async {


Moved to accounts.dart

Teskann · 2025-07-14T08:43:36Z

lib/client/client_regular_account.dart

  Future<void> deleteAccount(String username) async {
    var database = await Repository.writable();
    database.delete(tableAccounts, where: 'id = ?', whereArgs: [username]);
  }
-
-  Future<Map<dynamic, dynamic>?> getAuthHeader(BasePrefService prefs) async {


getAuthHeader was moved to headers.dart

prefs argument was unused so I removed it

Teskann · 2025-07-14T08:49:35Z

lib/l10n/intl_en.arb

+  "@x_client_transaction_id_provider": {},
+  "x_client_transaction_id_provider_description": "Set the x-client-transaction-id provider. It must he a domain name, without http/https prefix. For more information about it, check https://github.com/Teskann/x-client-transaction-id-generator",
+  "@x_client_transaction_id_provider_description": {}
+


Tell me if these strings look clear to you.

I could use an LLM to translate them to all languages Quacker supports. I didn't because I don't know what you think about it for this project. Tell me if you want me to do it

Teskann · 2025-07-14T08:53:30Z

lib/client/accounts.dart

@@ -0,0 +1,6 @@
+import 'package:quacker/database/repository.dart';


Before you start the review, let me precise this is the first time I work with Dart and a Flutter application. I'm a full time C++ developer. I don't know the best practices for Dart. I tried to mimicate the rest of the code but don't hesitate to ask me to do some corrections if needed :)

Teskann · 2025-07-14T08:59:16Z

lib/client/headers.dart

+        throw Exception('Failed to get x-client-transaction-id. Status code: ${response.statusCode}');
+      }
+    } catch (e) {
+      throw Exception('Error getting x-client-transaction-id: $e');


This exception will make it easy to know that x-client-transaction-id.xyz does not work anymore with this message for instance if the server is down.

If the transaction id is correctly generated but not valid on X's side, we will get the same 404 error as before. If 404 happen again in the future, we should consider taking a close look at the validity of the x-client-transaction-id and maybe we will have to update the server that provides it

As I'm the owner of the server & domain, I didn't want to block the app if any of these is down/sold. This is why I added an option to change the URL of the provider in the settings. Anybody could create its own instance. Of course in this case you should update the default URL in Quacker, but users would have a way to change it themselves without any app update

Teskann · 2025-07-14T09:14:26Z

My pleasure to help you on this project. It's amazing, I used it everyday when it worked. It's the best Fritter fork out there.

One thing about why I decided to rely on an external server to generate the x-client-transaction-id. As it relies on a Python package that has 100+ stars on github, a Discord community etc, it's very likely that it will be updated if the implementation does not work anymore. It will make it very easy to update Quacker because it won't be on our side.

This is why I decided not to "transalte" the Python implementation to Dart, even if it would have probably worked. This will reduce our maintainance and we won't have to manually reimplement every single commit that is pushed to the Python implementation. Just update the package version that the server uses and that's it.

I added several comments in the code to ease your review.

DUOLabs333 · 2025-08-10T02:52:00Z

Would it be possible to have the app start its own copy of the server locally, to avoid depending on the uptime of a third-party server?

Teskann commented Jul 13, 2025

View reviewed changes

Teskann mentioned this pull request Jul 13, 2025

[BUG] Feed doesn't work! #58

Open

Teskann force-pushed the master branch from 06ce43a to 0a7d7a7 Compare July 13, 2025 14:56

Implemented a way to get a valid x-client-transaction-id header for r…

9616f3f

…equests

Teskann force-pushed the master branch from 0a7d7a7 to 9616f3f Compare July 13, 2025 14:59

Teskann commented Jul 14, 2025

View reviewed changes

TheHCJ merged commit a024c91 into TheHCJ:master Jul 15, 2025

TheHCJ mentioned this pull request Jul 16, 2025

[BUG] doesn't work #59

Open

TheHCJ mentioned this pull request Jul 28, 2025

[BUG] Certein feeds causing NoSuchMethod error #65

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implemented a way to get a valid x-client-transaction-id header for requests #64

Implemented a way to get a valid x-client-transaction-id header for requests #64

Uh oh!

Teskann commented Jul 13, 2025

Uh oh!

Teskann Jul 13, 2025

Uh oh!

Teskann commented Jul 13, 2025

Uh oh!

Teskann commented Jul 13, 2025

Uh oh!

TheHCJ commented Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann Jul 14, 2025

Uh oh!

Teskann commented Jul 14, 2025

Uh oh!

DUOLabs333 commented Aug 10, 2025

Uh oh!

Uh oh!

		@@ -0,0 +1,6 @@
		import 'package:quacker/database/repository.dart';


		if (authHeader != null) {
		return await model.fetch(uri, headers: headers, log: log, prefs: prefs, authHeader: authHeader);

Implemented a way to get a valid x-client-transaction-id header for requests #64

Implemented a way to get a valid x-client-transaction-id header for requests #64

Uh oh!

Conversation

Teskann commented Jul 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Teskann commented Jul 13, 2025

Uh oh!

Teskann commented Jul 13, 2025

Uh oh!

TheHCJ commented Jul 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Teskann commented Jul 14, 2025

Uh oh!

DUOLabs333 commented Aug 10, 2025

Uh oh!

Uh oh!