Rocket refactoring + starting some features / fixes #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to drop item
combined with previous commit, this fixes TeamGalacticraft#324
player dismounts the rocket on the launch pad instead of above the rocket in the air. I made the dismount location one block south of the rocket (in the direction of the rocket window by default)
rewrote onPlace with helper functions to make it more readable. Should perform the same, but please report any bugs (note: bugs would arise from attempting to create a launchpad multiblock)
addresses issue TeamGalacticraft#323 and refactors onRemove code to be more readable
addresses changes requested by @marcus8448
rocket will launch without player if player exists and does not reenter / destroy rocket before countdown expires. Copies behavior from Galacticraft Legacy and fixes bug TeamGalacticraft#322
lander gets instantiated using information from the player, so the player needs to be teleported first before the lander can be created
…f GC vehicle types
also removed methods implemented by parent classes
a better organization of vehicles is based on which require fuel and which don't. Both types could be rideable, and if we were to use PlayerRideable as the parent class, then we would either have to reuse a lot of fuel-related code or make assumptions about other parent classes
…wable inventories I still assume that they will be containers, which I think is fair given that all GC vehicles I can think of store items in some way
turns out it did not enforce implementing those methods since they are already implemented in Entity
F is already used for off-hand swap
haven't got it quite working yet
|
Thanks for dealing with that stupid hangin' rocket bug! |
Roelymole
reviewed
Feb 7, 2025
| @@ -0,0 +1,22 @@ | |||
| package dev.galacticraft.api.rocket.entity; | |||
Contributor
There was a problem hiding this comment.
You need to add the license header at the top of each file.
| @@ -0,0 +1,59 @@ | |||
| package dev.galacticraft.mod.content.entity.vehicle; | |||
Contributor
There was a problem hiding this comment.
Missing license header here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.