Skip to content

fix(query-devtools): Update default devtools button position to bottom-right 🌱 #6720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2024
Merged

fix(query-devtools): Update default devtools button position to bottom-right 🌱 #6720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c09d4c8
docs: Update default position
agustints Jan 16, 2024
9d48a22
fix: Default btn position for React.js
agustints Jan 16, 2024
7d7975f
fix: Default btn position for Solid.js
agustints Jan 16, 2024
3b20e9e
fix: Default btn position for Svelte
agustints Jan 16, 2024
1531207
fix: Default btn position for Vue.js
agustints Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/angular/devtools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import { Component } from '@angular/core';
- `initialIsOpen: Boolean`
- Set this `true` if you want the dev tools to default to being open
- `buttonPosition?: "top-left" | "top-right" | "bottom-left" | "bottom-right"`
- Defaults to `bottom-left`
- Defaults to `bottom-right`
- The position of the TanStack logo to open and close the devtools panel
- `position?: "top" | "bottom" | "left" | "right"`
- Defaults to `bottom`
Expand Down
2 changes: 1 addition & 1 deletion docs/react/devtools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function App() {
- `initialIsOpen: Boolean`
- Set this `true` if you want the dev tools to default to being open
- `buttonPosition?: "top-left" | "top-right" | "bottom-left" | "bottom-right"`
- Defaults to `bottom-left`
- Defaults to `bottom-right`
- The position of the React Query logo to open and close the devtools panel
- `position?: "top" | "bottom" | "left" | "right"`
- Defaults to `bottom`
Expand Down
2 changes: 1 addition & 1 deletion docs/solid/devtools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function App() {
- `initialIsOpen: Boolean`
- Set this `true` if you want the dev tools to default to being open
- `buttonPosition?: "top-left" | "top-right" | "bottom-left" | "bottom-right"`
- Defaults to `bottom-left`
- Defaults to `bottom-right`
- The position of the Solid Query logo to open and close the devtools panel
- `position?: "top" | "bottom" | "left" | "right"`
- Defaults to `bottom`
Expand Down
2 changes: 1 addition & 1 deletion docs/vue/devtools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import { VueQueryDevtools } from '@tanstack/vue-query-devtools'
- `initialIsOpen: Boolean`
- Set this `true` if you want the dev tools to default to being open
- `buttonPosition?: "top-left" | "top-right" | "bottom-left" | "bottom-right"`
- Defaults to `bottom-left`
- Defaults to `bottom-right`
- The position of the React Query logo to open and close the devtools panel
- `position?: "top" | "bottom" | "left" | "right"`
- Defaults to `bottom`
Expand Down
2 changes: 1 addition & 1 deletion packages/react-query-devtools/src/devtools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface DevtoolsOptions {
/**
* The position of the React Query logo to open and close the devtools panel.
* 'top-left' | 'top-right' | 'bottom-left' | 'bottom-right'
* Defaults to 'bottom-left'.
* Defaults to 'bottom-right'.
*/
buttonPosition?: DevtoolsButtonPosition
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/solid-query-devtools/src/devtools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ interface DevtoolsOptions {
/**
* The position of the React Query logo to open and close the devtools panel.
* 'top-left' | 'top-right' | 'bottom-left' | 'bottom-right'
* Defaults to 'bottom-left'.
* Defaults to 'bottom-right'.
*/
buttonPosition?: DevtoolsButtonPosition
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte-query-devtools/src/Devtools.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
} from '@tanstack/query-devtools'

export let initialIsOpen = false
export let buttonPosition: DevtoolsButtonPosition = 'bottom-left'
export let buttonPosition: DevtoolsButtonPosition = 'bottom-right'
export let position: DevtoolsPosition = 'bottom'
export let client: QueryClient = useQueryClient()
export let errorTypes: Array<DevToolsErrorType> = []
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-query-devtools/src/devtools.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const devtools = new TanstackQueryDevtools({
})

watchEffect(() => {
devtools.setButtonPosition(props.buttonPosition || 'bottom-left')
devtools.setButtonPosition(props.buttonPosition || 'bottom-right')
devtools.setPosition(props.position || 'bottom')
devtools.setInitialIsOpen(props.initialIsOpen)
devtools.setErrorTypes(props.errorTypes || [])
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-query-devtools/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export interface DevtoolsOptions {
/**
* The position of the React Query logo to open and close the devtools panel.
* 'top-left' | 'top-right' | 'bottom-left' | 'bottom-right'
* Defaults to 'bottom-left'.
* Defaults to 'bottom-right'.
*/
buttonPosition?: DevtoolsButtonPosition
/**
Expand Down