[TASK] Add TYPO3\CMS\Core\Attribute\AsAllowedCallable attribute #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Member
|
I tested this the other way round with https://review.typo3.org/c/Packages/TYPO3.CMS/+/91797 in v13: Have the attribute used in TF, but do NOT have the attribute class in core. This is to see what happens when updated TF (with PR applied) is used with non-updated / released core. It seems PHP just ignores attributes when it can't resolve it. That's fine. I think we're good to go. |
lolli42
approved these changes
Nov 21, 2025
sbuerk
approved these changes
Nov 21, 2025
Member
Author
|
Nice! Thx folks |
Member
Author
|
Here's the finalization in TYPO3 Update: Done as well ✅ |
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 21, 2025
Executed commands: composer up typo3/testing-framework Corresponding testing framework change: TYPO3/testing-framework#694 Resolves: #108239 Releases: main Change-Id: I60dbe0a500e81f2960df59aaf6ed508eec8c0640 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91800 Tested-by: Oli Bartsch <[email protected]> Tested-by: core-ci <[email protected]> Tested-by: Christian Kuhn <[email protected]> Tested-by: Oliver Klee <[email protected]> Tested-by: Oliver Hader <[email protected]> Reviewed-by: Oli Bartsch <[email protected]> Reviewed-by: Oliver Klee <[email protected]> Reviewed-by: Christian Kuhn <[email protected]> Reviewed-by: Oliver Hader <[email protected]>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Nov 21, 2025
Executed commands: composer up typo3/testing-framework Corresponding testing framework change: TYPO3/testing-framework#694 Resolves: #108239 Releases: main Change-Id: I60dbe0a500e81f2960df59aaf6ed508eec8c0640 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91800 Tested-by: Oli Bartsch <[email protected]> Tested-by: core-ci <[email protected]> Tested-by: Christian Kuhn <[email protected]> Tested-by: Oliver Klee <[email protected]> Tested-by: Oliver Hader <[email protected]> Reviewed-by: Oli Bartsch <[email protected]> Reviewed-by: Oliver Klee <[email protected]> Reviewed-by: Christian Kuhn <[email protected]> Reviewed-by: Oliver Hader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.