Skip to content

[BUGFIX] Enforce classic mode in created TYPO3 entrypoint files #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbuerk merged 1 commit into from
Dec 3, 2024
Merged

[BUGFIX] Enforce classic mode in created TYPO3 entrypoint files #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 36 additions & 11 deletions Classes/Core/Testbase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,23 +239,50 @@ public function setUpInstanceCoreLinks(
$installPhpExists = file_exists($instancePath . '/typo3/sysext/install/Resources/Private/Php/install.php');
if ($hasConsolidatedHttpEntryPoint) {
$entryPointsToSet = [
$instancePath . '/typo3/sysext/core/Resources/Private/Php/index.php' => $instancePath . '/index.php',
[
'source' => $instancePath . '/typo3/sysext/core/Resources/Private/Php/index.php',
'target' => $instancePath . '/index.php',
'pattern' => '/\\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::run\(\);/',
'replacement' => '\TYPO3\TestingFramework\Core\SystemEnvironmentBuilder::run(0, 0, false);',
],
];
if ($installPhpExists && in_array('install', $coreExtensions, true)) {
$entryPointsToSet[$instancePath . '/typo3/sysext/install/Resources/Private/Php/install.php'] = $instancePath . '/typo3/install.php';
$entryPointsToSet[] = [
'source' => $instancePath . '/typo3/sysext/install/Resources/Private/Php/install.php',
'target' => $instancePath . '/typo3/install.php',
'pattern' => '/\\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::run\(1\);/',
'replacement' => '\TYPO3\TestingFramework\Core\SystemEnvironmentBuilder::run(1, 0, false);',
];
}
} else {
$entryPointsToSet = [
$instancePath . '/typo3/sysext/backend/Resources/Private/Php/backend.php' => $instancePath . '/typo3/index.php',
$instancePath . '/typo3/sysext/frontend/Resources/Private/Php/frontend.php' => $instancePath . '/index.php',
[
'source' => $instancePath . '/typo3/sysext/backend/Resources/Private/Php/backend.php',
'target' => $instancePath . '/typo3/index.php',
'pattern' => '/\\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::run\(1, \\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::REQUESTTYPE_BE\);/',
'replacement' => '\TYPO3\TestingFramework\Core\SystemEnvironmentBuilder::run(1, \TYPO3\CMS\Core\Core\SystemEnvironmentBuilder::REQUESTTYPE_BE, false);',
],
[
'source' => $instancePath . '/typo3/sysext/frontend/Resources/Private/Php/frontend.php',
'target' => $instancePath . '/index.php',
'pattern' => '/\\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::run\(0, \\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::REQUESTTYPE_FE\);/',
'replacement' => '\TYPO3\TestingFramework\Core\SystemEnvironmentBuilder::run(0, \TYPO3\CMS\Core\Core\SystemEnvironmentBuilder::REQUESTTYPE_FE, false);',
],
];
if ($installPhpExists) {
$entryPointsToSet[$instancePath . '/typo3/sysext/install/Resources/Private/Php/install.php'] = $instancePath . '/typo3/install.php';
$entryPointsToSet[] = [
'source' => $instancePath . '/typo3/sysext/install/Resources/Private/Php/install.php',
'target' => $instancePath . '/typo3/install.php',
'pattern' => '/\\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::run\(1, \\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::REQUESTTYPE_INSTALL\);/',
'replacement' => '\TYPO3\TestingFramework\Core\SystemEnvironmentBuilder::run(1, \TYPO3\CMS\Core\Core\SystemEnvironmentBuilder::REQUESTTYPE_INSTALL, false);',
];
}
}
$autoloadFile = dirname(__DIR__, 4) . '/autoload.php';

foreach ($entryPointsToSet as $source => $target) {
foreach ($entryPointsToSet as $entryPointToSet) {
$source = $entryPointToSet['source'];
$target = $entryPointToSet['target'];
if (($entryPointContent = file_get_contents($source)) === false) {
throw new \UnexpectedValueException(sprintf('Source file (%s) was not found.', $source), 1636244753);
}
Expand All @@ -264,11 +291,9 @@ public function setUpInstanceCoreLinks(
$this->findShortestPathCode($target, $autoloadFile),
$entryPointContent
);
$entryPointContent = (string)preg_replace(
'/\\\\TYPO3\\\\CMS\\\\Core\\\\Core\\\\SystemEnvironmentBuilder::run\(/',
'\TYPO3\TestingFramework\Core\SystemEnvironmentBuilder::run(',
$entryPointContent
);
$pattern = $entryPointToSet['pattern'];
$replacement = $entryPointToSet['replacement'];
$entryPointContent = (string)preg_replace($pattern, $replacement, $entryPointContent);
if ($entryPointContent === '') {
throw new \UnexpectedValueException(
sprintf('Error while customizing the source file (%s).', $source),
Expand Down