This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Fix for #131 #165
Open
Fix for #131 #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, implementation of isAfterMinDate and isAfterMinDate is after/before OR EQUAL so if we ask do I want to see prev/next month/year button we should check if last day of previous month/year is after minDate (not first day of current month/year) and check if first day of next month/year is before maxDate (not last day of current month/year).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
implementation of isAfterMinDate and isAfterMinDate is after/before OR EQUAL so if we ask do I want to see prev/next month/year button we should check if last day of previous month/year is after minDate (not first day of current month/year) and check if first day of next month/year is before maxDate (not last day of current month/year).