Fix modifications of settings & saving #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the settings are accumulated in a ChainMap, they would have to either be accessed via `settings.maps[1].save()` or via an explicitly named global. I chose the latter, since it does not rely on the `ChainMap` order and is more explicit. The same also applies to writing to the `ChainMap` before, of course.
rchl
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the settings are accumulated in a ChainMap, they would have to either be accessed via
settings.maps[1].save()or via an explicitly named global.I chose the latter, since it does not rely on the
ChainMaporder and is more explicit.The same also applies to writing to the
ChainMapbefore, of course.Should fix #156 but changes are untested (I simply made the code changes and don't use the package).