Skip to content

Do not ignore spaces when comitting critic markup #797

@frederik-elwert

Description

@frederik-elwert

According to the logic of critic markup, leading/trailing spaces are meaningful. See, e.g., the example of the official critic markup documentation:

Lorem ipsum dolor{++ sit++} amet...

Here, since a new word is added, the leading space before the "sit" is relevant.

The current macros, however, discard leading/trailing spaces when committing critic markup. This leads to newly inserted words being glued to the surrounding text. Currently, when committing the change via the macro, the resulting text would be

Lorem ipsum dolorsit amet...

The expected result, instead, would be

Lorem ipsum dolor sit amet...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions