Exit the process gracefully #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Nov 8, 2021
trueeyu
reviewed
Nov 9, 2021
chaoyli
force-pushed
the
main
branch
5 times, most recently
from
a55632d to
9d97e0e
Compare
|
run starrocks_be_unittest |
chaoyli
force-pushed
the
main
branch
2 times, most recently
from
8fead21 to
103f2a0
Compare
sduzh
reviewed
Nov 10, 2021
sduzh
requested changes
Nov 10, 2021
sduzh
reviewed
Nov 11, 2021
sduzh
reviewed
Nov 11, 2021
chaoyli
force-pushed
the
main
branch
2 times, most recently
from
d42c20e to
4093e0c
Compare
|
run starrocks_be_unittest |
It's to used to detect memory leak upon exiting the process. Every thread in StorageEngine is already check the existed state. If the existed state is set to be true, the thread will be exited. But the the thread and the class in StarRocks is not seperated very well. So the pull request do the best effort to the graceful exiting.
It's to used to detect memory leak upon exiting the process. Every thread in StorageEngine is already check the existed state. If the existed state is set to be true, the thread will be exited. But the the thread and the class in StarRocks is not seperated very well. So the pull request do the best effort to the graceful exiting.
sduzh
reviewed
Nov 11, 2021
sduzh
reviewed
Nov 11, 2021
sduzh
approved these changes
Nov 12, 2021
trueeyu
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's to used to detect memory leak upon exiting the process.
Every thread in StorageEngine is already check the existed state.
If the existed state is set to be true, the thread will be exited.
But the the thread and the class in StarRocks is not seperated very well.
So the pull request do the best effort to the graceful exiting.