-
Notifications
You must be signed in to change notification settings - Fork 136
chore: add span percentile in trace details #2378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @nityanandagohain's task in 1m 33s —— View job Documentation ReviewTasks
SummaryThis PR successfully adds documentation for the span percentile feature in the trace details page. The changes are well-structured and follow most documentation guidelines. I've identified a few minor issues for improvement. Issues FoundMinor Issues:
PR Checklist ComplianceReviewing against the PR Checklist:
Note on image format: The images are in PNG format. Per CONTRIBUTING.md guidelines (line 267), WebP format ( Technical AccuracyThe span percentile documentation is technically accurate. The feature description aligns with standard OpenTelemetry span performance analysis practices, where percentiles (p50, p90, p95, p99) are commonly used to identify performance outliers and understand latency distributions across distributed traces. Sources: RecommendationThis documentation is ready to merge after addressing the two minor inline comments. The content effectively explains the new span percentile feature and provides clear visual examples for users. |
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Fixes https://github.com/SigNoz/engineering-pod/issues/3264
Adds details about span percentile.