-
Notifications
You must be signed in to change notification settings - Fork 136
chore(install): adds install guide of signoz for haschicorp nomad #2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @Nageshbansal's task —— View job Review Complete: Install guide for HashiCorp NomadI've reviewed the new Nomad installation guide against the repository's CONTRIBUTING.md guidelines. The documentation is technically accurate and well-structured overall, but needs several improvements to meet the documentation standards. Summary of Findings✅ What's Working Well:
📋 Required Changes (per CONTRIBUTING.md):
🔧 Style & Formatting Issues:
❓ Needs Clarification:
Minor Suggestions:
Verification SourcesAll technical details were verified against official sources: PR Checklist StatusComparing against the Docs PR Checklist:
Once these items are addressed, this will be a solid addition to the SigNoz documentation. |
| { | ||
| type: 'doc', | ||
| label: 'Deploying to HashiCorp Nomad', | ||
| route: '/docs/setup/nomad', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| route: '/docs/setup/nomad', | |
| route: '/docs/install/nomad', |
Why setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we start adding new docs in setup only now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The motive of the setup was to focus solely on the installation docs; we've been pushing docs to install/. My intention was to adapt to the new structure.
makeavish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makeavish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have broken down this into multiple pages to make it simple?

Related: https://github.com/SigNoz/platform-pod/issues/1061