Skip to content

GeneralIndexModule internal review and external audit revisions #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgewecke merged 41 commits into from
Apr 22, 2021
Merged

GeneralIndexModule internal review and external audit revisions #75

Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
fab902d
Make all revert reason strings < 32bytes
cgewecke Apr 16, 2021
1e74243
Remove _normalizedTargetMethod getter
cgewecke Apr 16, 2021
d43c5ae
Encapsulate _noTokensToSell#canSell logic as internal method
cgewecke Apr 16, 2021
2053ac0
Encapsulate _allTargetsMet#targetUnmet logic in internal method
cgewecke Apr 16, 2021
ef484a6
Validate exchange adapter when setting & store name as bytes32 hash
cgewecke Apr 19, 2021
1b8def4
Consolidate position state and timestamp updates
cgewecke Apr 19, 2021
de523b9
Validate params for external view methods
cgewecke Apr 19, 2021
62795dd
Make all external setter method names use prefix `set`
cgewecke Apr 19, 2021
70ae790
Add RebalanceStarted event
cgewecke Apr 19, 2021
0e19bf8
Add inline comments and normalize line spacing
cgewecke Apr 19, 2021
b637a06
Remove _caller param from onlyAllowedTrader modifier
cgewecke Apr 19, 2021
2a8efd0
Add getDefaultPositionRealUnit getter
cgewecke Apr 19, 2021
fe71725
Revert use bytes32 hash for exchange adapter id in #setExchanges
cgewecke Apr 20, 2021
eb52c56
Encapsulate setter methods param validation logic
cgewecke Apr 20, 2021
233dcb4
Encapsulate data aggregation logic in #startRebalance in own method
cgewecke Apr 20, 2021
d5b6bdb
Prohibit external positions for components in #initialize and #startR…
cgewecke Apr 20, 2021
bd71c56
Use TradeModule var naming for sellAmount, netBuyAmount in trade methods
cgewecke Apr 20, 2021
3f18496
Rename _componentQuantityLimit to _minComponentReceived in #tradeRema…
cgewecke Apr 21, 2021
3f0112d
Refactor #createTradeInfo methods and use TradeModule naming conventi…
cgewecke Apr 21, 2021
e9f704b
Fix external position module tests
cgewecke Apr 21, 2021
c520f00
Revert `isSell`, `minReceiveQuantity` var name changes
cgewecke Apr 21, 2021
c0f1dad
Declare tradeInfo return param in #_createTrade.. #_getDefaultTrade..…
cgewecke Apr 21, 2021
344e6c8
Make weth state variable immutable
cgewecke Apr 21, 2021
90cf09d
Fix typos detected in audit
cgewecke Apr 21, 2021
bb0f3ff
Add PositionMultiplierUpdated event and emit in #raiseAssetTargets
cgewecke Apr 21, 2021
f62d5f2
Optimize external position checks in #startRebalance and #initialize
cgewecke Apr 21, 2021
23ce583
Delegate modifier logic to internal helpers in ModuleBase and General…
cgewecke Apr 22, 2021
181753b
Restrict #_getAggregateComponentsAndUnits state mutability to pure
cgewecke Apr 22, 2021
5fbbf43
Delete trader permissions on module removal / add removeModule tests
cgewecke Apr 22, 2021
c3fe5ab
Add #validatePairsWithArray methods to AddressArrayUtils library
cgewecke Apr 22, 2021
7f02665
Use AddressArrayUtils #validatePairs... methods in GeneralIndexModule
cgewecke Apr 22, 2021
ef185b8
Add false trader status case to #removeModule tests for coverage report
cgewecke Apr 22, 2021
52a4b08
Add approximatelyEquals helper in PreciseUnitMath and use in #_target…
cgewecke Apr 22, 2021
1ff05b5
Fix file newlines & TS error, normalize permissions comments naming
cgewecke Apr 22, 2021
00f49b8
Rename PositionMultiplierUpdated event to AssetTargetsRaised
cgewecke Apr 22, 2021
280417c
Fix validatePairsWithArray bytes method / update lib changelogs
cgewecke Apr 22, 2021
215b6ef
Remove trader from permissionInfo.tradersHistory when they are de-aut…
cgewecke Apr 22, 2021
493c6a6
Inline protocol fee comment in _calculateTradeSizeAndDirection
cgewecke Apr 22, 2021
d1ebe6e
Use #removeStorage instead of #remove in #_updateTradersHistory
cgewecke Apr 22, 2021
770b584
Add getAllowedTraders method and make tradersHistory contain unique e…
cgewecke Apr 22, 2021
7229465
Fix TS error
cgewecke Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading