Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@shriya-deshmukh
Copy link
Contributor

@shriya-deshmukh shriya-deshmukh commented Sep 5, 2022

Signed-off-by: Shriya Deshmukh [email protected]

Problem Statement

  • If the container contains multiple compressed log '.gz' files in that case RGW support bundle collection is failing with -9 error code, which means the process is killed via SIGKILL. It's probably due to the machine/node running out of memory or the script needing too much memory and the OS kernel was triggering the OOM killer.
  • It is failing while reading the larger size .gz file contents using gzip.readline().

Design

  • Instead of reading the .gz file contents, include these files in the support bundle if file creation time is in between the given time duration.

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]:
  • Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]:
  • Confirm that Test Cases are added for new features added [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM/K8s deployment [Y/N]: Y

Review Checklist

Before posting the PR please ensure:

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • New package/s added to setup.py?
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

  • ConfStore
  • KVStore
  • ConfCli
  • Test cases added for all above 3
  • changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

  • Changes done to WIKI / Confluence page

Copy link
Contributor

@sachitanands sachitanands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@shriya-deshmukh shriya-deshmukh force-pushed the CORTX-34138 branch 2 times, most recently from 2f41afd to 02e7f98 Compare September 12, 2022 06:59
Signed-off-by: Shriya Deshmukh <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants