Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@shriya-deshmukh
Copy link
Contributor

@shriya-deshmukh shriya-deshmukh commented Aug 25, 2022

Signed-off-by: Shriya Deshmukh [email protected]

Problem Statement

  • Support bundle creation is failing in limit_time filter for rotated log (.gz) files.

Design

  • For now to unblock the sanity skip rotated files while applying limit_time filter during log collection.

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]:
  • Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]:
  • Confirm that Test Cases are added for new features added [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM/K8s deployment [Y/N]:

Review Checklist

Before posting the PR please ensure:

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • New package/s added to setup.py?
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

  • ConfStore
  • KVStore
  • ConfCli
  • Test cases added for all above 3
  • changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

  • Changes done to WIKI / Confluence page

@cdeshmukh cdeshmukh merged commit 9df754d into Seagate:main Aug 26, 2022
@shriya-deshmukh shriya-deshmukh deleted the CORTX-34050 branch August 29, 2022 03:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants