Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@lakshita-jain
Copy link
Contributor

@lakshita-jain lakshita-jain commented Aug 22, 2022

Signed-off-by: Lakshita Jain [email protected]

Problem Statement

  • Removing query deployment Interface from Utils as per the discussions with Ujjwal and CSM team as this will be taken up in future sprints with a generic approach.

Design

  • This PR involves removing the query_deployemnt folder and updating setup.py file

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]:
  • Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]:
  • Confirm that Test Cases are added for new features added [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM/K8s deployment [Y/N]:

Review Checklist

Before posting the PR please ensure:

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • New package/s added to setup.py?
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

  • ConfStore
  • KVStore
  • ConfCli
  • Test cases added for all above 3
  • changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

  • Changes done to WIKI / Confluence page

Copy link
Contributor

@kupranay kupranay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert back original commit instead of creating a new commit

Copy link

@nitin-seagate nitin-seagate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lakshita-jain
Copy link
Contributor Author

lakshita-jain commented Aug 23, 2022

Please revert back original commit instead of creating a new commit

There were two PRs for the same in the main and had multiple commits hence we opted for deleting the Interface instead of reverting the PRs/ previous commits for this feature.

@tanujashinde0405 tanujashinde0405 merged commit 7b37589 into main Aug 24, 2022
@tanujashinde0405 tanujashinde0405 deleted the CORTX-33877-1 branch August 24, 2022 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants