CORTX-33673: Improvement for lock-unlock interface with lock end time…

[tanujashinde0405]

… implementation

Signed-off-by: Tanuja Shinde [email protected]

Problem Statement

• Improve lock unlock interfaces code written in utils by adding the duration of lock to be acquired by a thread.

Design

Added new parameter in lock as duration which will update for how much time a thread can acquire lock.
if a new thread wants to acquire the lock, test_lock() interface will check if the lock_end time which is calculated by duration is less than current time and if the new thread can acquire the lock or not.

Test Cases

from cortx.utils.conf_store import Conf
Conf.load('p0', 'consul://ssc-vm-g3-rhev4-3306.colo.seagate.com/conf8')
Conf.load('p1', 'consul://ssc-vm-g3-rhev4-3306.colo.seagate.com/conf8')
Conf.load('p2', 'consul://ssc-vm-g3-rhev4-3306.colo.seagate.com/conf8')

1. test "lock" interface

Conf.lock('p0', owner='p0', domain='prov', duration=30)
True

2. test "test_lock" interface

Conf.test_lock('p1', owner='p1', domain='prov')
False

3. test "unlock" interface

Conf.unlock('p0', owner='p0', domain='prov')
True

4. test "lock" repeat

Conf.lock('p0', owner='p0', domain='prov', duration=30)
True
Conf.lock('p0', owner='p0', domain='prov', duration=30)
True
Conf.lock('p1', owner='p1', domain='prov', duration=30)
False
Conf.lock('p0', owner='p0', domain='prov', duration=30)
True

5. lock at one thread and test “lock” from a different thread

Conf.lock('p0', owner='p0', domain='prov', duration=30)
True
Conf.lock('p1', owner='p1', domain='prov', duration=30)
False

6. lock at one thread and test “unlock” from a different thread

Conf.lock('p0', owner='p0', domain='prov', duration=30)
True
Conf.unlock('p1', owner='p1', domain='prov')
False

7. test “unlock” repeat

Conf.unlock('p1', owner='p1', domain='prov')
False
Conf.unlock('p1', owner='p1', domain='prov')
False
Conf.unlock('p1', owner='p1', domain='prov')
False

8. lock with two different domains

Conf.lock('p0', owner='p0', domain='prov', duration=30)
True
Conf.lock('p0', owner='p0', domain='hare', duration=30)
True

9. lock from one thread and test “unlock with force=true” from another thread

Conf.lock('p0', owner='p0', domain='prov', duration=30)
True
Conf.unlock('p1', owner='p1', domain='prov', force=True)
True

10. unlock from one thread and test “lock” from another

Conf.unlock('p1', owner='p1', domain='prov', force=True)
True
Conf.lock('p0', owner='p0', domain='prov', duration=30)
True

Coding

• Coding conventions are followed and code is consistent [Y/N]:
• Confirm All CODACY errors are resolved [Y/N]:

Testing

• Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]:
• Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]:
• Confirm that Test Cases are added for new features added [Y/N]:
• Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
• Confirm Testing was performed with installed RPM/K8s deployment [Y/N]:

Review Checklist

Before posting the PR please ensure:

• PR is self reviewed
• Is there a change in filename/package/module or signature [Y/N]:
• If yes for above point, Is a notification sent to all other cortx components [Y/N]
• New package/s added to setup.py?
• Jira is updated
• Check if the description is clear and explained.
• Check Acceptance Criterion is defined.
• All the tests performed should be mentioned before Resolving a JIRA.
• Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

• ConfStore
• KVStore
• ConfCli
• Test cases added for all above 3
• changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

• Changes done to WIKI / Confluence page

[nitin-seagate]

LGTM

[tanujashinde0405]

5 Node deployment successful with utils and provisioner feature branch:
https://eos-jenkins.colo.seagate.com/job/Cortx-Automation/job/RGW/job/setup-cortx-rgw-cluster/10825/