Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@sachitanands
Copy link
Contributor

@sachitanands sachitanands commented Aug 5, 2022

Signed-off-by: Sachitanand Shelake [email protected]

Problem Statement

  • With Gconfstore migration to consul, there is structural change on the way we fetch any component list values. Eariler sprint we have fixed for actual utils code but somehow we missed this change for support bundle script in utils.

Design

  • For fetching component names list, first we need to fetch num_components key and then iterate over this number for fetching actual component name key.
  • similar changes required for fetching services names.

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]: N
  • Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]: N
  • Confirm that Test Cases are added for new features added [Y/N]: N
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: N
  • Confirm Testing was performed with installed RPM/K8s deployment [Y/N]: Y

Review Checklist

Before posting the PR please ensure:

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]: N
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • New package/s added to setup.py?
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

  • ConfStore
  • KVStore
  • ConfCli
  • Test cases added for all above 3
  • changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

  • Changes done to WIKI / Confluence page

@sachitanands
Copy link
Contributor Author

sachitanands commented Aug 5, 2022

Tested this change on existing cluster.
image

Triggered 1 Node deployment manually
https://eos-jenkins.colo.seagate.com/job/Cortx-Automation/job/RGW/job/setup-cortx-rgw-cluster/10487/ ( in-progress)
docker images :
cortx-docker.colo.seagate.com/seagate/cortx-control:2.0.0-600-py-utils-pr
cortx-docker.colo.seagate.com/seagate/cortx-data:2.0.0-600-py-utils-pr
cortx-docker.colo.seagate.com/seagate/cortx-server:2.0.0-600-py-utils-pr

@sachitanands
Copy link
Contributor Author

retest this please

@tanujashinde0405 tanujashinde0405 merged commit cb08735 into main Aug 5, 2022
@welcome
Copy link

welcome bot commented Aug 5, 2022

Thanks for your contribution to CORTX! 🎉

@sachitanands sachitanands deleted the br/sachit/CORTX-33790 branch August 7, 2022 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants