This repository was archived by the owner on Feb 8, 2024. It is now read-only.
motr_sync, rgw_sal_motr: [CORTX-34177] refactor Motr Locking code #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjxsg
reviewed
Sep 9, 2022
jjxsg
approved these changes
Sep 9, 2022
|
@sumedhak27 can you please add ostream prefix for logs for motr sync similar to what we have added for garbage collector. |
DPG17
approved these changes
Sep 9, 2022
- Add `dpp` in `MotrLock` class as a private member and initialize it. - Refactor the method and the call to the method `remove_lock(...)`. - Add virtual destructors in MotrSync & MotrLockProvider classes. - Move the log level declarations from the `rgw_sal_motr.cc` to the `rgw_sal_motr.h` file. Signed-off-by: Sumedh Anantrao Kulkarni <[email protected]>
sumedhak27
force-pushed
the
motr/locking/expire_lock
branch
from
c2d8cfb to
d702998
Compare
jjxsg
approved these changes
Sep 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dppinMotrLockclass as a private member and initialize it.remove_lock(...).rgw_sal_motr.ccto thergw_sal_motr.hfile.Signed-off-by: Sumedh Anantrao Kulkarni [email protected]
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox