Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@shraddhaghatol
Copy link

Problem: Getting "UnknownError" while performing copy object using tagging directive COPY on source object with no tags
Solution : Error occurs only when we put fresh object (without tagging) in bucket and perform copy-object operation with --tagging -directive COPY. No need to return error if empty tags are present. Even if tags are empty copy operation should get successful with --tagging-directive COPY.

If tags are empty we were returning with -66 error from copy_object_same_zone() function.

Signed-off-by: shraddhaghatol [email protected]

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the rgw label Sep 8, 2022
@shraddhaghatol shraddhaghatol marked this pull request as ready for review September 8, 2022 12:18
@shraddhaghatol shraddhaghatol self-assigned this Sep 8, 2022
Copy link

@priyanka25081999 priyanka25081999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean patch

…tive COPY on source object with no tags

Signed-off-by: shraddhaghatol <[email protected]>
@shraddhaghatol
Copy link
Author

Ran ceph tests. All tests are successful.
following is the job link::
https://eos-jenkins.colo.seagate.com/job/Cortx-Automation/job/S3Server/job/S3-Compatibility-Test-Ceph-RGW/240/
image

Copy link

@sachitanands sachitanands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cdeshmukh cdeshmukh merged commit be07ae4 into main Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants