Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

rgw_sal_motr: [CORTX-34122] support versioned multipart delete using GC #415

Merged
merged 2 commits into from
Sep 5, 2022
Merged

rgw_sal_motr: [CORTX-34122] support versioned multipart delete using GC #415

merged 2 commits into from
Sep 5, 2022

Conversation

@sumedhak27
Copy link

@sumedhak27 sumedhak27 commented Sep 2, 2022 •
edited
Loading

Commit 1:
Fixing the part index table name to make it work for both
versioned and unversioned multipart objects.

Commit 2:
Added a utility function in the Meta class to get the string version of OID.

Signed-off-by: Sumedh Anantrao Kulkarni [email protected]

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sumedhak27
rgw_sal_motr: [CORTX-34122] support versioned multipart delete using GC
526f779 
Fixing the part index table name to make it work for both
versioned and unversioned multipart objects.

Signed-off-by: Sumedh Anantrao Kulkarni <[email protected]>
@github-actions github-actions bot added the rgw label Sep 2, 2022
@sumedhak27
rgw_sal_motr,motr_gc: [CORTX-34122] Improve OID str generation logic
d0fb2d4 
Added a Meta::oid_str() method, to get string version of oid.

Signed-off-by: Sumedh Anantrao Kulkarni <[email protected]>
@sumedhak27 sumedhak27 requested a review from DPG17 September 2, 2022 08:48
sachinpunadikar
sachinpunadikar reviewed Sep 5, 2022
View reviewed changes
sachinpunadikar
sachinpunadikar approved these changes Sep 5, 2022
View reviewed changes
Copy link

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit 1e124eb into Seagate:main Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@DPG17 DPG17 DPG17 approved these changes

@jjxsg jjxsg jjxsg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

rgw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sumedhak27 @sachinpunadikar @DPG17 @jjxsg