Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@priyanka25081999
Copy link

@priyanka25081999 priyanka25081999 commented Aug 24, 2022

Problem statement:

  • Improve logs level in RGW SAL layer

Solution:

  • Introduced the macros for log level mapping
  • Remove redundant logs
  • Updated the code formats as per guidelines
  • Added __func__ in log statement

Signed-off-by: Priyanka Salunke [email protected]

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the rgw label Aug 24, 2022
@priyanka25081999 priyanka25081999 self-assigned this Aug 24, 2022
Copy link

@cdeshmukh cdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep PR in draft state, since WIP

@priyanka25081999 priyanka25081999 changed the title [WIP] rgw_sal_motr : [CORTX-33020] Improve log levels of SAL layer rgw_sal_motr : [CORTX-33020] Improve log levels of SAL layer Aug 25, 2022
@priyanka25081999
Copy link
Author

retest this please

Copy link

@jjxsg jjxsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priyanka25081999
Copy link
Author

retest this please

@priyanka25081999
Copy link
Author

priyanka25081999 commented Aug 30, 2022

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@sachitanands sachitanands merged commit 5e919e3 into Seagate:main Aug 30, 2022
@priyanka25081999 priyanka25081999 deleted the ps/logs-33020 branch August 30, 2022 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants