Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@shraddhaghatol
Copy link

@shraddhaghatol shraddhaghatol commented Aug 10, 2022

Problem:
Observed discrepancy with AWS for CopyObject API's response.
In MGW, "etag" field was not included in ("/ /")

Resolution:
Included etag field of CopyObject API's response in ("/ /") to make it AWS compliant

Corresponding Ceph PR ceph#47527, until that is merged, we are not supposed to merge this one, as changes in RGW Common code.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the rgw label Aug 10, 2022
@shraddhaghatol shraddhaghatol self-assigned this Aug 10, 2022
@shraddhaghatol shraddhaghatol marked this pull request as ready for review August 10, 2022 08:41
Copy link

@priyanka25081999 priyanka25081999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cdeshmukh cdeshmukh changed the title rgw_sal_motr : [CORTX-33755] Added Cosmetic change in etag of copyObjectResult [DO NOT MERGE until Ceph PR #47527 merged] rgw_sal_motr : [CORTX-33755] Added Cosmetic change in etag of copyObjectResult Aug 10, 2022
@cdeshmukh cdeshmukh changed the title [DO NOT MERGE until Ceph PR #47527 merged] rgw_sal_motr : [CORTX-33755] Added Cosmetic change in etag of copyObjectResult [DO NOT MERGE until Ceph PR #47527 merged] [CORTX-33755] Added Cosmetic change in etag of copyObjectResult Aug 10, 2022
@shraddhaghatol shraddhaghatol force-pushed the shr/33755_cosmetic_changes branch from 717c07e to 9277df8 Compare August 16, 2022 04:05
@shraddhaghatol shraddhaghatol force-pushed the shr/33755_cosmetic_changes branch from 9277df8 to 984eec1 Compare August 16, 2022 04:07
@cdeshmukh
Copy link

@shraddhaghatol Ceph PR merged ceph#47527 (comment)

@cdeshmukh cdeshmukh changed the title [DO NOT MERGE until Ceph PR #47527 merged] [CORTX-33755] Added Cosmetic change in etag of copyObjectResult [CORTX-33755] Added Cosmetic change in etag of copyObjectResult Sep 2, 2022
@shraddhaghatol
Copy link
Author

Ran S3-Compatibility-Test-Ceph-RGW test. It is successful with known failures.
Following is the job link - https://eos-jenkins.colo.seagate.com/job/Cortx-Automation/job/S3Server/job/S3-Compatibility-Test-Ceph-RGW/232/#showFailuresLink
image

@cdeshmukh cdeshmukh merged commit fbf40ba into main Sep 6, 2022
@sachitanands sachitanands deleted the shr/33755_cosmetic_changes branch September 6, 2022 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants