Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@shraddhaghatol
Copy link

@shraddhaghatol shraddhaghatol commented Aug 8, 2022

Problem : Object tagging tests were failing intermittently due to tags were not set through setObjectTagging API.

Solution : For multipart object case, in setObjectTagging API, code was returning success code without setting tag values to given object hence removing this code.For Multipart objects, tagging support is already handled in different flow.

Signed-off-by: shraddhaghatol [email protected]

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Signed-off-by: shraddhaghatol <[email protected]>
@github-actions github-actions bot added the rgw label Aug 8, 2022
@shraddhaghatol
Copy link
Author

@shraddhaghatol shraddhaghatol marked this pull request as ready for review August 8, 2022 12:26
@shraddhaghatol shraddhaghatol self-assigned this Aug 8, 2022
Copy link

@sachitanands sachitanands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

@priyanka25081999 priyanka25081999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shraddhaghatol
Copy link
Author

@shraddhaghatol
Copy link
Author

Done manual testing which includes simple and Multipart object tagging testing with versioning.
https://jts.seagate.com/browse/CORTX-33574?focusedCommentId=2412056&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2412056

@sachitanands sachitanands merged commit 52c700d into main Aug 9, 2022
@sachitanands sachitanands deleted the shr/33574-tagging-issue branch August 9, 2022 04:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants