Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@sachitanands
Copy link
Contributor

@sachitanands sachitanands commented Sep 5, 2022

If user provide any of these parameters in solution.yaml file then we will skip resource limit based formula calculation and we will pick up user specified value.
if solution.yaml file does not has these keys in extra_configuration section then we will generate values using resource limit based formula.

example soultion.yaml ,

"
   s3:
      default_iam_users:
        auth_admin: sgiamadmin
        auth_user: user_name
      max_start_timeout: 240
      instances_per_node: '1'
      extra_configuration: |
thread_pool_size: 30
max_concurrent_requests: 33
        enable_gc_threads: 'false'
"
Signed-off-by: Sachitanand Shelake [email protected]

Problem Statement

  • Problem statement

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

…er to solution.yaml

Signed-off-by: Sachitanand Shelake <[email protected]>
@cla-bot cla-bot bot added the cla-signed label Sep 5, 2022
@sachitanands sachitanands changed the title Patch for exposing thread_pool_size & max_concurrent_requests paramet… T[Do not merge] temporary patch for exposing thread_pool_size & max_concurrent_requests parameters in solution.yaml for testing purpose Sep 5, 2022
@sachitanands sachitanands changed the title T[Do not merge] temporary patch for exposing thread_pool_size & max_concurrent_requests parameters in solution.yaml for testing purpose [Do not merge] temporary patch for exposing thread_pool_size & max_concurrent_requests parameters in solution.yaml for testing purpose Sep 5, 2022
Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
@sachitanands
Copy link
Contributor Author

retest this please

@sachitanands sachitanands changed the title [Do not merge] temporary patch for exposing thread_pool_size & max_concurrent_requests parameters in solution.yaml for testing purpose CORTX-34161: exposing thread_pool_size & max_concurrent_requests parameters in solution.yaml for rgw Sep 6, 2022
@sachitanands sachitanands self-assigned this Sep 6, 2022
Copy link
Contributor

@priyanka25081999 priyanka25081999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdeshmukh cdeshmukh merged commit 8e0bd62 into main Sep 6, 2022
@sachitanands sachitanands deleted the resource-limit-config branch September 6, 2022 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants