Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@sachitanands
Copy link
Contributor

Signed-off-by: Sachitanand Shelake [email protected]

Problem Statement

  • Problem statement
    Observed performance impact if we enable rgw logging on console.

  • Solution
    Disable logging messages for rgw service to console.
    [client.rgw-1]
    log to file = true
    log to stderr = false
    err to stderr = false

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

@sachitanands sachitanands self-assigned this Aug 29, 2022
@cla-bot cla-bot bot added the cla-signed label Aug 29, 2022
@sachitanands sachitanands changed the title Disable rgw logging into console Disabling console logging of rgw service due to performance impact. Aug 29, 2022
Copy link
Contributor

@cdeshmukh cdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz add defect id to commit message & title

@sachitanands sachitanands changed the title Disabling console logging of rgw service due to performance impact. CORTX-33944:Disabling console logging of rgw service due to performance impact. Aug 29, 2022
Copy link
Contributor

@priyanka25081999 priyanka25081999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sachitanands sachitanands force-pushed the br/sachit/RGWLogChanges branch from ddafb4d to 440c35f Compare August 29, 2022 13:10
@cdeshmukh cdeshmukh changed the title CORTX-33944:Disabling console logging of rgw service due to performance impact. CORTX-33944:Disabling RGW service console logging to address performance issue Aug 29, 2022
@cdeshmukh cdeshmukh merged commit b52d023 into main Aug 29, 2022
@sachitanands sachitanands deleted the br/sachit/RGWLogChanges branch August 29, 2022 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants