Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@sachitanands
Copy link
Contributor

@sachitanands sachitanands commented Aug 25, 2022

Signed-off-by: Sachitanand Shelake [email protected]

Problem Statement

  • While starting rgw service, we redirect all the logs to one file which captures all the motr, gc logs to this file.
    With latest changes, these logs are already captured hence we don't need to dump into the log file. hence removing this file itself.
  • Update m0trace, m0addb log rotation scripts present in /etc/cron.hourly with proper PVC path where motr client logs are stored in rgw container.

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Copy link
Contributor

@cdeshmukh cdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With latest changes, these logs are already captured

In PR description, update where / how these are captured now, for completeness of understanding for someone looking at PR

@sachitanands sachitanands force-pushed the br/sachit/CORTX-33043 branch from cf23f71 to e7643b7 Compare August 29, 2022 13:39
Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
@sachitanands sachitanands force-pushed the br/sachit/CORTX-33043 branch from 34dbfe4 to d4d06ca Compare August 30, 2022 13:00
Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
@sachitanands sachitanands changed the title CORTX-33043: removing rgw startup log file CORTX-33043: Update motr log rotate scripts with proper PVC log path and removing rgw startup log file Aug 30, 2022
@sachitanands
Copy link
Contributor Author

Tested this changes with 1 node deployment ,
https://eos-jenkins.colo.seagate.com/job/Cortx-Automation/job/RGW/job/setup-cortx-rgw-cluster/11993/console

Docker images :

cortx-docker.colo.seagate.com/seagate/cortx-control:2.0.0-147-rgw-integration-pr
cortx-docker.colo.seagate.com/seagate/cortx-data:2.0.0-147-rgw-integration-pr
cortx-docker.colo.seagate.com/seagate/cortx-control:2.0.0-147-rgw-integration-pr

  1. changes in motr log rotate script :
    image

  2. kubernetes container logs with this patch,
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants