Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@sachitanands
Copy link
Contributor

Updated user creation logic as below

  1. Move rgw admin creation from config phase to init phase .
  • changes suggested by motr team because after hare init phase, motr endpoint will be available. hence rgw should try user creation after this step.
  1. Expose admin user creation timeout & retry count parameter as part of GConf and user can set this through solution.yaml.
ADMIN_USER_CREATION_TIMEOUT_KEY = f'cortx>{COMPONENT_NAME}>admin_creation_timeout'
ADMIN_USER_CREATION_MAX_RETRY_KEY =  f'cortx>{COMPONENT_NAME}>admin_creation_max_retry'
ADMIN_USER_CREATION_DEFAULT_TIMEOUT = 600
ADMIN_USER_CREATION_MAX_DEFAULT_RETRY = 1

Signed-off-by: Sachitanand Shelake [email protected]

Problem Statement

  • Problem statement

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

…config phase to init phase

Signed-off-by: Sachitanand Shelake <[email protected]>
@sachitanands
Copy link
Contributor Author

with this changes 1 Node and 3 Node deployment. deployment was successful.

  1. 1 Node user creation logs in rgw,

1Nodedeployment

  1. 3 Node user creation logs in rgw,
    3Nodedeployment

Copy link
Contributor

@priyanka25081999 priyanka25081999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sachitanand Shelake <[email protected]>
@sachitanands
Copy link
Contributor Author

retest this please

@sachitanands
Copy link
Contributor Author

image

@cdeshmukh cdeshmukh merged commit fd95102 into main Aug 25, 2022
@sachitanands sachitanands deleted the br/sachit/CORTX-34035 branch August 26, 2022 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants