Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@sachitanands
Copy link
Contributor

Signed-off-by: Sachitanand Shelake [email protected]

Problem Statement

  • Handle clean up of rgw core files using /etc/logrotate.d scripts.

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Copy link
Contributor

@priyanka25081999 priyanka25081999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Sachitanand Shelake <[email protected]>
Copy link
Contributor

@cdeshmukh cdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also address codacy issues

Signed-off-by: Sachitanand Shelake <[email protected]>
Signed-off-by: Sachitanand Shelake <[email protected]>
@sachitanands sachitanands force-pushed the br/sachit/CORTX-32039 branch from 7393638 to c0e5481 Compare August 22, 2022 13:10
Signed-off-by: Sachitanand Shelake <[email protected]>
@cdeshmukh cdeshmukh merged commit 1d8dc76 into main Aug 23, 2022
@sachitanands sachitanands deleted the br/sachit/CORTX-32039 branch August 26, 2022 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants