CORTX-32172: Fixes ADDB client logs to bundled it in rgw support bundle

[rahul27kumar]

Signed-off-by: Rahul Kumar [email protected]

Problem Statement

The addb client logs in rgw container is generating in wrong directory (rgw_debug). This "rgw_debug" directories meant for rgw crash files only. Our expectation, addb client logs should be resides in "addb_files-0x7200000000000001:0x13" directory.

Design

• For Bug, required to create an environment variable for addb directories in "rgw_services.py"

Coding

Checklist for Author

• Coding conventions are followed and code is consistent

Testing

Checklist for Author

• Unit and System Tests are added
• Test Cases cover Happy Path, Non-Happy Path and Scalability
• Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

• Interface change (if any) are documented
• Side effects on other features (deployment/upgrade)
• Dependencies on other component(s)

Review Checklist

Checklist for Author

• JIRA number/GitHub Issue added to PR
• PR is self reviewed
• Jira and state/status is updated and JIRA is updated with PR link
• Check if the description is clear and explained

Documentation

Checklist for Author

• Changes done to WIKI / Confluence page / Quick Start Guide

[sachitanands]

looks good

[sachitanands]

one minor comment

[rahul27kumar]

After modification, our requirement doesn't meet:

[root@cortx-server-0 ac2f9656e38a92990522025e1f3ccaef]# tree
.
|-- addb_files-0x7200000000000001:0x13
|-- motr_trace_files
|   |-- m0trace.10.2022-08-05-05:27:39
|   `-- m0trace.413.2022-08-05-05:27:01
|-- radosgw-admin.log
|-- rgw-1.log
|-- rgw_debug
|   |-- addb_10
|   |   |-- id
|   |   `-- o
|   |       `-- 100000000000000:2
|   `-- addb_413
|       |-- id
|       `-- o
|           `-- 100000000000000:2
|-- rgw_setup.log
`-- rgw_startup.log

7 directories, 10 files
[root@cortx-server-0 ac2f9656e38a92990522025e1f3ccaef]# 

@sachitanands Above modification is required to collect addb logs at addb_files-0x7200000000000001:0x13 .

[rahul27kumar]

@sachitanands Shall I revert it back to previous version of my PR?

[sachitanands]

@sachitanands Shall I revert it back to previous version of my PR?

If its not working then I think the environment variable you added is not working that means.

[rahul27kumar]

@sachitanands With previous patch, it was working as expected like below you can see:

[root@cortx-server-0 rgw]# tree
.
`-- ac2f9656e38a92990522025e1f3ccaef
    |-- addb_files-0x7200000000000001:0x13
    |   `-- addb_10
    |       |-- id
    |       `-- o
    |           `-- 100000000000000:2
    |-- motr_trace_files
    |   `-- m0trace.10.2022-08-03-07:37:46
    |-- rgw-1.log
    |-- rgw_debug
    |-- rgw_setup.log
    |-- rgw_startup.log
    `-- rgw_support_bundle.log
6 directories, 7 files

[rahul27kumar]

@sachitanands Now final fixes also done from motr code as well. Now this functionality looks fine and it gives result as expected.

[root@cortx-server-0 ac2f9656e38a92990522025e1f3ccaef]# tree
.
|-- addb_files-0x7200000000000001:0x7
|   |-- addb_10
|   |   |-- id
|   |   `-- o
|   |       `-- 100000000000000:2
|   `-- addb_398
|       |-- id
|       `-- o
|           `-- 100000000000000:2
|-- motr_trace_files
|   |-- m0trace.10.2022-08-17-14:49:02
|   `-- m0trace.398.2022-08-17-14:48:19
|-- radosgw-admin.log
|-- rgw-1.log
|-- rgw_debug
|-- rgw_setup.log
`-- rgw_startup.log

7 directories, 10 files
[root@cortx-server-0 ac2f9656e38a92990522025e1f3ccaef]#

[rahul27kumar]

Finally outcomes after new patches:
custom_images: https://eos-jenkins.colo.seagate.com/job/GitHub-custom-ci-builds/job/generic/job/custom-ci/7587/console

[root@ssc-vm-rhev4-2700 ac2f9656e38a92990522025e1f3ccaef]# ls
addb_files-0x7200000000000001:0x7  motr_trace_files  radosgw-admin.log  rgw-1.log  rgw_debug  rgw_setup.log  rgw_startup.log
[root@ssc-vm-rhev4-2700 ac2f9656e38a92990522025e1f3ccaef]# tree
.
├── addb_files-0x7200000000000001:0x7
│   ├── addb_11
│   │   ├── id
│   │   └── o
│   │       └── 100000000000000:2
│   └── addb_398
│       ├── id
│       └── o
│           └── 100000000000000:2
├── motr_trace_files
│   ├── m0trace.11.2022-08-18-12:27:18
│   └── m0trace.398.2022-08-18-12:26:59
├── radosgw-admin.log
├── rgw-1.log
├── rgw_debug
├── rgw_setup.log
└── rgw_startup.log
7 directories, 10 files
[root@ssc-vm-rhev4-2700 ac2f9656e38a92990522025e1f3ccaef]#

[sachitanands]

looks good

[cdeshmukh]

1N deployment was successfull before rebase
https://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Cortx-Deployment/job/Generic/job/rgw-integration/119/