CORTX-33037: apply support bundle filter limit_size

[rohit-k-dwivedi]

Signed-off-by: rohit-k-dwivedi [email protected]
JIRA: CORTX-33037

Problem Statement

• No limit_size filter available

Design

• Created patch to apply limit_size filter.
  limits number of cores when limit_size is passed and truncates text logs if the size still exceeds

Coding

Checklist for Author

• Coding conventions are followed and code is consistent

Testing

Checklist for Author

• Unit and System Tests are added
• Test Cases cover Happy Path, Non-Happy Path and Scalability
• Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

• Interface change (if any) are documented
• Side effects on other features (deployment/upgrade)
• Dependencies on other component(s)

Review Checklist

Checklist for Author

• JIRA number/GitHub Issue added to PR
• PR is self reviewed
• Jira and state/status is updated and JIRA is updated with PR link
• Check if the description is clear and explained

Documentation

Checklist for Author

• Changes done to WIKI / Confluence page / Quick Start Guide

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[rohit-k-dwivedi]

@cdeshmukh @sachitanands @rahul-tripathi-git please review.

[sachitanands]

looks good

[rohit-k-dwivedi]

@cdeshmukh ,
with latest changes, collects 2 (rgw_debug/core2.core, rgw_debug/core3.core) cores when has enough size limit but restricts to 1 core if size is limited, + all logs truncated when passed 1B as size limit

################## SIZE LIMIT IS 10GB  ####################
[root@cortx-server-headless-svc-ssc-vm-rhev4-2782 ~]# /opt/seagate/cortx/rgw/bin/rgw_support_bundle -t SB -c yaml:///etc/cortx/cluster.conf -b 200 --all True --size_limit 10GB
[root@cortx-server-headless-svc-ssc-vm-rhev4-2782 ~]# tar -tvf SB/rgw/rgw_200.tar.gz
tar: Removing leading `/' from member names
drwxr-xr-x root/root         0 2022-07-28 04:26 /
drwxr-xr-x root/root         0 2022-07-25 12:32 addb_files-0x7200000000000001:0x5/
-rw-r--r-- root/root      1758 2022-07-28 04:25 cortx_rgw.conf
-rw-r--r-- root/root      6878 2022-07-28 04:25 radosgw-admin.log
-rw-r--r-- root/root      8712 2022-07-28 04:25 rgw_setup.log
-rw-r--r-- root/root        98 2022-07-28 04:26 rgw_live_callstack.log
-rw-r--r-- root/root     16550 2022-07-28 04:26 cortx-rpms
-rw-r--r-- root/root    572633 2022-07-28 04:25 rgw-1.log
drwxr-xr-x root/root         0 2022-07-28 04:26 rgw_debug/
-rw-r--r-- root/root 1073741824 2022-07-28 04:26 rgw_debug/core2.core
-rw-r--r-- root/root 1073741824 2022-07-28 04:26 rgw_debug/core3.core
drwxr-xr-x root/root          0 2022-07-28 04:26 motr_trace_files/
-rw-r--r-- root/root     963452 2022-07-28 04:26 motr_trace_files/m0trace.382.2022-07-25-12:31:48.yaml.xz
-rw-r--r-- root/root    1674848 2022-07-28 04:26 motr_trace_files/m0trace.10.2022-07-25-12:32:05.yaml.xz
-rw-r--r-- root/root       1557 2022-07-28 04:25 rgw_startup.log
-rw-r--r-- root/root       3792 2022-07-28 04:25 rgw_support_bundle.log

################## SIZE LIMIT IS 1B  ####################
[root@cortx-server-headless-svc-ssc-vm-rhev4-2782 ~]# /opt/seagate/cortx/rgw/bin/rgw_support_bundle -t SB -c yaml:///etc/cortx/cluster.conf -b 200 --size_limit 1B
[root@cortx-server-headless-svc-ssc-vm-rhev4-2782 ~]# tar -tvf SB/rgw/rgw_200.tar.gz
tar: Removing leading `/' from member names
drwxr-xr-x root/root         0 2022-07-28 04:28 /
drwxr-xr-x root/root         0 2022-07-25 12:32 addb_files-0x7200000000000001:0x5/
-rw-r--r-- root/root      1758 2022-07-28 04:27 cortx_rgw.conf
-rw-r--r-- root/root         0 2022-07-28 04:28 radosgw-admin.log
-rw-r--r-- root/root      8712 2022-07-28 04:27 rgw_setup.log
-rw-r--r-- root/root     16550 2022-07-28 04:28 cortx-rpms
-rw-r--r-- root/root    572633 2022-07-28 04:27 rgw-1.log
drwxr-xr-x root/root         0 2022-07-28 04:28 motr_trace_files/
-rw-r--r-- root/root    963544 2022-07-28 04:28 motr_trace_files/m0trace.382.2022-07-25-12:31:48.yaml.xz
-rw-r--r-- root/root   1674848 2022-07-28 04:27 motr_trace_files/m0trace.10.2022-07-25-12:32:05.yaml.xz
-rw-r--r-- root/root      1557 2022-07-28 04:27 rgw_startup.log
-rw-r--r-- root/root         0 2022-07-28 04:28 rgw_support_bundle.log
[root@cortx-server-headless-svc-ssc-vm-rhev4-2782 ~]#

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cla-bot]

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

[cdeshmukh]

@shriya-deshmukh Why 'verification/cla-signed' is failing for you, you had contributed already so many times to this repo. Is it because original author was Rohit ?

[shriya-deshmukh]

@shriya-deshmukh Why 'verification/cla-signed' is failing for you, you had contributed already so many times to this repo. Is it because original author was Rohit ?

This check is failing for Rohit's commit

2022-08-26T10:05:23.625Z INFO The contributors @rohit-k-dwivedi have not signed the CLA, adding error status to the pull request