CORTX-33129: Enable 26motr-user-kernel-tests ST which is disabled for libfabric #2140
Conversation
imvenkip
requested review from
andriytk,
huanghua78,
madhavemuri,
mehjoshi,
nikitadanilov,
nkommuri,
rkothiya,
sg-shankar,
shashank-parulekar,
siningwuseagate,
vidyadhar-pinglikar,
yatin-mahajan and
yeshpal-jain-seagate
as code owners
imvenkip
force-pushed
the
CORTX-33129
branch
from
82c252e to
c98e05f
Compare
Jenkins CI Result : Motr#1746Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
… libfabric Analysis: ST 26motr-user-kernel-tests are dependent on the m0tr(mount_m0t1fs) and motr_st_kmod.ko modules. Due to that reason it was disabled. We have to remove kernel module dependency. Fix: Following fixes are added to enable 26motr-user-kernel-tests ST for libfabric * First issue is resolved by not sending HA events to clients, and which will get these states during startup from dummy HA m0d. * Removed m0tr.ko dependency. * Removed motr_st_kmod.ko module dependency tests. Signed-off-by: Venkateswarlu Payidimarry <[email protected]>
imvenkip
force-pushed
the
CORTX-33129
branch
from
c98e05f to
3b4a894
Compare
Jenkins CI Result : Motr#1749Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
Jenkins CI Result : Motr#1752Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
Jenkins CI Result : Motr#1751Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
… libfabric Changed ST's order to avoid failures. Signed-off-by: Venkateswarlu Payidimarry <[email protected]>
|
[Suggestion] |
yatin-mahajan
left a comment
yatin-mahajan
left a comment
There was a problem hiding this comment.
Approving with one minor suggestion.
Looks good to me.
Jenkins CI Result : Motr#1757Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
… libfabric Test doesn't have kernel mode test, so renamed from "26motr-user-kernel-tests" to "26motr-user-tests". Signed-off-by: Venkateswarlu Payidimarry <[email protected]>
|
retest this please |
1 similar comment
|
retest this please |
Jenkins CI Result : Motr#1762Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
7 participants
Problem Statement
Enable 26motr-user-kernel-tests ST which is disabled for libfabric
Design
ST 26motr-user-kernel-tests are dependent on the m0tr(mount_m0t1fs) and motr_st_kmod.ko modules. Due to that reason it was disabled. We have to remove kernel module dependency.
Fix:
Following fixes are added to enable 26motr-user-kernel-tests ST for libfabric
* First issue is resolved by not sending HA events to clients, and which will get these states during startup from
dummy HA m0d.
* Removed m0tr.ko dependency.
* Removed motr_st_kmod.ko module dependency tests.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author