Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

CORTX-33703: Codacy Cleanup #2094

Merged
merged 1 commit into from
Aug 22, 2022
Merged

CORTX-33703: Codacy Cleanup #2094

merged 1 commit into from
Aug 22, 2022

Conversation

@rkothiya
Copy link
Contributor

@rkothiya rkothiya commented Aug 21, 2022

Removed 2035.diff file.

Signed-off-by: Rinku Kothiya [email protected]

Problem Statement

Unable to list ST's

Design

Removed file 2035.diff

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

@rkothiya
CORTX-33703: Codacy Cleanup
7ab3301 
Removed 2035.diff file. It is not required.

Signed-off-by: Rinku Kothiya <[email protected]>
@cla-bot cla-bot bot added the cla-signed label Aug 21, 2022
@rkothiya
Copy link
Contributor Author

rkothiya commented Aug 22, 2022

Giving an exception for ci/cd as this file got added unintentionally and it not part of code.

@rkothiya rkothiya added the Exception Allowed to merge without runing ut and st label Aug 22, 2022
@rkothiya rkothiya merged commit f8a476d into Seagate:main Aug 22, 2022
kiwionly2 pushed a commit to kiwionly2/cortx-motr that referenced this pull request Aug 30, 2022
@rkothiya @kiwionly2
CORTX-33703: Codacy Cleanup (Seagate#2094)
3d51192 
Problem: 
Unable to list ST's

Solution: 
Removed 2035.diff file. It is not required.

Signed-off-by: Rinku Kothiya <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mehjoshi mehjoshi Awaiting requested review from mehjoshi

@madhavemuri madhavemuri Awaiting requested review from madhavemuri

@nikitadanilov nikitadanilov Awaiting requested review from nikitadanilov

@yeshpal-jain-seagate yeshpal-jain-seagate Awaiting requested review from yeshpal-jain-seagate

@huanghua78 huanghua78 Awaiting requested review from huanghua78

@andriytk andriytk Awaiting requested review from andriytk andriytk is a code owner

@siningwuseagate siningwuseagate Awaiting requested review from siningwuseagate siningwuseagate is a code owner

@vidyadhar-pinglikar vidyadhar-pinglikar Awaiting requested review from vidyadhar-pinglikar

@shashank-parulekar shashank-parulekar Awaiting requested review from shashank-parulekar

@nkommuri nkommuri Awaiting requested review from nkommuri nkommuri is a code owner

@sg-shankar sg-shankar Awaiting requested review from sg-shankar

@yatin-mahajan yatin-mahajan Awaiting requested review from yatin-mahajan

2 more reviewers

@anaghadeshmukh anaghadeshmukh anaghadeshmukh approved these changes

@upendrapatwardhan upendrapatwardhan upendrapatwardhan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nikitadanilov nikitadanilov

@madhavemuri madhavemuri

@mehjoshi mehjoshi

Labels

cla-signed Exception Allowed to merge without runing ut and st

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rkothiya @anaghadeshmukh @upendrapatwardhan @nikitadanilov @madhavemuri @mehjoshi