CORTX-29983: UT and ST fixed with DTM0 #2076
Conversation
huanghua78
requested review from
andriytk,
madhavemuri,
mehjoshi,
nikitadanilov,
nkommuri,
rkothiya,
sg-shankar,
shashank-parulekar,
siningwuseagate,
vidyadhar-pinglikar,
yatin-mahajan and
yeshpal-jain-seagate
as code owners
huanghua78
force-pushed
the
ut_st_with_dtm
branch
from
6959af1 to
377fd30
Compare
Jenkins CI Result : Motr#1607Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
dtm0/recovery.c
Outdated
| eolq_post(rf->rf_m, | ||
| &(struct eolq_item) { | ||
| .ei_type = EIT_HA, | ||
| .ei_type = EIT_EOL, |
There was a problem hiding this comment.
Can you post the fix in a separate PR ?
I think after 1503 PR is landed, we might not use DTM_ENABLE flag.
There was a problem hiding this comment.
Removed from this PR.
But I think this is a bug, isn't it?
There was a problem hiding this comment.
I mean can you create a separate PR for the bug .
huanghua78
force-pushed
the
ut_st_with_dtm
branch
from
377fd30 to
87e883b
Compare
The REDO messages might come as a re-send, so the replay should be indempotent. So checking if the eolq is already ended is necessary. Signed-off-by: Hua Huang <[email protected]>
huanghua78
force-pushed
the
ut_st_with_dtm
branch
from
87e883b to
305d2ca
Compare
|
https://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Motr/1645/ is started with default configuration. |
Jenkins CI Result : Motr#1645Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
Jenkins CI Result : Motr#1647Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
Jenkins CI Result : Motr#1651Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
Jenkins CI Result : Motr#1652Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
There are 4 Jenkins tests triggered, and UT failed due to stuck in the following case: and and and |
|
I tested the "rpc-link-ut " on main branch, and it passes 10 iterations and then |
|
"rpc-link-ut -n 20" also passed 10 iterations locally. |
madhavemuri
changed the title
6 participants
Problem Statement
Design
and continue the operations. This is used to have UT and ST pass when DTM is enabled
when building Motr. In future, when DTM is ready to be enabled by default, these
temporary workaround should be removed.
The REDO message replay must be idempotent. So checking if the eolq is ended or not
before putting the item to the queue.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author