CORTX-32172: Fixes ADDB client logs to bundled it in rgw support bundle #2059

rahul27kumar · 2022-08-08T06:02:53Z

Signed-off-by: Rahul Kumar [email protected]

Problem Statement

The addb client logs in rgw container is generating in wrong directory (rgw_debug). This "rgw_debug" directories meant for rgw crash files only. Our expectation, addb client logs should be resides in "addb_files-0x7200000000000001:0x13" directory.

Design

It's required to set an environment for M0_CLIENT_ADDB_DIR on cortx-rgw-integration repository in src/rgw/setup/rgw.py at config stage.
In cortx-motr, motr>client_init.c will make use of M0_CLIENT_ADDB_DIR environment variable to store addb client log.

Coding

Checklist for Author

Coding conventions are followed and code is consistent

Testing

Checklist for Author

Unit and System Tests are added
Test Cases cover Happy Path, Non-Happy Path and Scalability
Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

Interface change (if any) are documented
Side effects on other features (deployment/upgrade)
Dependencies on other component(s)

Review Checklist

Checklist for Author

JIRA number/GitHub Issue added to PR
PR is self reviewed
Jira and state/status is updated and JIRA is updated with PR link
Check if the description is clear and explained

Documentation

Checklist for Author

Changes done to WIKI / Confluence page / Quick Start Guide

motr/client_init.c

rkothiya · 2022-08-23T21:24:24Z

Jenkins CI Result : Motr#1628

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	43	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/73motr-io-small-disks 04motr-single-node/48motr-raid0-io 04motr-single-node/74motr-di-corruption-detection 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	77	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

motr/client_init.c

Signed-off-by: Rahul Kumar <[email protected]>

rkothiya · 2022-08-24T13:02:00Z

Jenkins CI Result : Motr#1632

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	43	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/73motr-io-small-disks 04motr-single-node/48motr-raid0-io 04motr-single-node/74motr-di-corruption-detection 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	77	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

rkothiya · 2022-08-24T14:33:01Z

retest this please

rkothiya · 2022-08-24T15:38:48Z

As per discussion with @chandradharraval giving an exception for DTM-integration Test pre-merge job.
Rocky Linux Deployment is now renamed to "Hare and Motr only non k8s deployment" which is passing now.

…le (Seagate#2059) Problem: The addb client logs in rgw container is generating in wrong directory (rgw_debug). This "rgw_debug" directories meant for rgw crash files only. Our expectation, addb client logs should be resides in "addb_files-0x7200000000000001:0x13" directory. Solution: It's required to set an environment for M0_CLIENT_ADDB_DIR on cortx-rgw-integration repository in src/rgw/setup/rgw.py at config stage. In cortx-motr, client_init.c will make use of M0_CLIENT_ADDB_DIR environment variable to store addb client log. Signed-off-by: Rahul Kumar <[email protected]>

cla-bot bot added the cla-signed label Aug 8, 2022

rahul27kumar force-pushed the CORTX-32172 branch from 0d4a774 to a8baef9 Compare August 9, 2022 08:22

hessio added the Status: Draft PR is a draft label Aug 9, 2022

rahul27kumar force-pushed the CORTX-32172 branch 13 times, most recently from 11c1b43 to a96896c Compare August 17, 2022 13:18

rahul27kumar force-pushed the CORTX-32172 branch from a96896c to 6283f5d Compare August 17, 2022 14:18

rahul27kumar marked this pull request as ready for review August 17, 2022 15:35

rahul27kumar requested review from andriytk, huanghua78, madhavemuri, mehjoshi, nikitadanilov, nkommuri, sg-shankar, shashank-parulekar, siningwuseagate, vidyadhar-pinglikar, yatin-mahajan and yeshpal-jain-seagate as code owners August 17, 2022 15:35

rahul27kumar force-pushed the CORTX-32172 branch 2 times, most recently from 9bba9f5 to 448f129 Compare August 23, 2022 09:38

rahul27kumar requested review from yeshpal-jain-seagate and removed request for mehjoshi August 23, 2022 09:40

yeshpal-jain-seagate approved these changes Aug 23, 2022

View reviewed changes

mehjoshi reviewed Aug 23, 2022

View reviewed changes

motr/client_init.c Outdated Show resolved Hide resolved

rahul27kumar force-pushed the CORTX-32172 branch 2 times, most recently from 2f7b4b3 to d93e8f5 Compare August 23, 2022 15:36