Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

Conversation

@prasanna46dk
Copy link
Contributor

@prasanna46dk prasanna46dk commented Aug 4, 2022

Signed-off-by: Prasanna Kulkarni [email protected]

Problem Statement

  • core-traces and m0iscorrupt file used for verifying
    already known issues in old btree code since new btree
    code is added and old btree code is removed from source
    these two files not useful anymore.

Design

  • Remove m0iscorrupt and core-traces files from source
    tree

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Compilation successful after removing files

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

Problem:

core-traces and m0iscorrupt file used for verifying
already known issues in old btree code since new btree
code is added and old btree code is removed from source
these two files not usuful anymore.

Solution:

Remove m0iscorrupt and core-traces files from source
tree

Signed-off-by: Prasanna Kulkarni <[email protected]>
Problem:

core-traces and m0iscorrupt file used for verifying
already known issues in old btree code since new btree
code is added and old btree code is removed from source
these two files not usuful anymore.

Solution:

Remove m0iscorrupt and core-traces files from source
tree

Signed-off-by: Prasanna Kulkarni <[email protected]>
@rkothiya
Copy link
Contributor

rkothiya commented Aug 4, 2022

Jenkins CI Result : Motr#1564

Motr Test Summary

Test ResultCountInfo
❌Failed2
📁

04motr-single-node/49motr-rpc-cancel
01motr-single-node/00userspace-tests

🏁Skipped31
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/08spiel-sns-repair-quiesce
04motr-single-node/28sys-kvs-kernel
04motr-single-node/11m0t1fs-rconfc-fail
04motr-single-node/08spiel-sns-repair
04motr-single-node/19sns-repair-abort
04motr-single-node/22sns-repair-ios-fail
05motr-single-node/18sns-repair-quiesce
05motr-single-node/12fwait
05motr-single-node/16sns-repair-multi
05motr-single-node/07mount-fail
05motr-single-node/15sns-repair-single
05motr-single-node/23sns-abort-quiesce
05motr-single-node/17sns-repair-concurrent-io
05motr-single-node/07mount
05motr-single-node/07mount-multiple
05motr-single-node/12fsync

✔️Passed42
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/01kernel-tests
01motr-single-node/03console
01motr-single-node/37protocol
01motr-single-node/02rpcping
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/53clusterusage-alert
02motr-single-node/41motr-conf-update
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/08spiel-multi-confd
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
04motr-single-node/48motr-raid0-io
04motr-single-node/25m0kv
04motr-single-node/44motr-rm-lock-cc-io
04motr-single-node/45motr-rmw
05motr-single-node/23dix-repair-m0repair
05motr-single-node/43motr-sync-replication
05motr-single-node/42motr-utils
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/40motr-dgmode
05motr-single-node/23dix-repair-quiesce-m0repair
05motr-single-node/23spiel-dix-repair-quiesce
05motr-single-node/44motr-sns-repair
05motr-single-node/23spiel-dix-repair

Total75🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@huanghua78
Copy link

Do we need to remove other places?

[cortx-motr]$ git grep m0iscorrupt
Makefile.am:                 utils/m0iscorrupt \
debian/cortx-motr.install:usr/sbin/m0iscorrupt
utils/Makefile.sub:              utils/m0iscorrupt \

And do we need to remove the utils/m0iscorrupt itself?

@prasanna46dk
Copy link
Contributor Author

Do we need to remove other places?

[cortx-motr]$ git grep m0iscorrupt
Makefile.am:                 utils/m0iscorrupt \
debian/cortx-motr.install:usr/sbin/m0iscorrupt
utils/Makefile.sub:              utils/m0iscorrupt \

And do we need to remove the utils/m0iscorrupt itself?

@yeshpal-jain-seagate can you confirm should we remove this or not?

@yeshpal-jain-seagate
Copy link
Contributor

Do we need to remove other places?

[cortx-motr]$ git grep m0iscorrupt
Makefile.am:                 utils/m0iscorrupt \
debian/cortx-motr.install:usr/sbin/m0iscorrupt
utils/Makefile.sub:              utils/m0iscorrupt \

And do we need to remove the utils/m0iscorrupt itself?

Yes, this changes are also also required,
rpms build should have failed because there is no file available.

Problem:

core-traces and m0iscorrupt file used for verifying
already known issues in old btree code since new btree
code is added and old btree code is removed from source
these two files not usuful anymore.

Solution:

Remove m0iscorrupt and core-traces files from source
tree

Signed-off-by: Prasanna Kulkarni <[email protected]>
@prasanna46dk
Copy link
Contributor Author

prasanna46dk commented Aug 5, 2022

Do we need to remove other places?

[cortx-motr]$ git grep m0iscorrupt
Makefile.am:                 utils/m0iscorrupt \
debian/cortx-motr.install:usr/sbin/m0iscorrupt
utils/Makefile.sub:              utils/m0iscorrupt \

And do we need to remove the utils/m0iscorrupt itself?

Done. Makefile.am and Makefile.sub changes are already present but added debian/cortx-motr.install

@hessio hessio added the Status: Waiting to be merged PR is waiting for a gatekeeper to merge it label Aug 9, 2022
@rkothiya
Copy link
Contributor

rkothiya commented Aug 9, 2022

Jenkins CI Result : Motr#1577

Motr Test Summary

Test ResultCountInfo
❌Failed2
📁

04motr-single-node/49motr-rpc-cancel
01motr-single-node/00userspace-tests

🏁Skipped31
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/08spiel-sns-repair-quiesce
04motr-single-node/28sys-kvs-kernel
04motr-single-node/11m0t1fs-rconfc-fail
04motr-single-node/08spiel-sns-repair
04motr-single-node/19sns-repair-abort
04motr-single-node/22sns-repair-ios-fail
05motr-single-node/18sns-repair-quiesce
05motr-single-node/12fwait
05motr-single-node/16sns-repair-multi
05motr-single-node/07mount-fail
05motr-single-node/15sns-repair-single
05motr-single-node/23sns-abort-quiesce
05motr-single-node/17sns-repair-concurrent-io
05motr-single-node/07mount
05motr-single-node/07mount-multiple
05motr-single-node/12fsync

✔️Passed42
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/01kernel-tests
01motr-single-node/03console
01motr-single-node/37protocol
01motr-single-node/02rpcping
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/53clusterusage-alert
02motr-single-node/41motr-conf-update
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/08spiel-multi-confd
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
04motr-single-node/48motr-raid0-io
04motr-single-node/25m0kv
04motr-single-node/44motr-rm-lock-cc-io
04motr-single-node/45motr-rmw
05motr-single-node/23dix-repair-m0repair
05motr-single-node/43motr-sync-replication
05motr-single-node/42motr-utils
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/40motr-dgmode
05motr-single-node/23dix-repair-quiesce-m0repair
05motr-single-node/23spiel-dix-repair-quiesce
05motr-single-node/44motr-sns-repair
05motr-single-node/23spiel-dix-repair

Total75🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@rkothiya
Copy link
Contributor

retest this please

@rkothiya rkothiya merged commit 8d1faf5 into Seagate:main Aug 10, 2022
@prasanna46dk prasanna46dk deleted the CORTX-33829 branch August 10, 2022 08:42
kiwionly2 pushed a commit to kiwionly2/cortx-motr that referenced this pull request Aug 30, 2022
Problem:
core-traces and m0iscorrupt file were used for verifying
known issues in old btree code, since new btree
code is added and old btree code is removed from source
these two files are not useful anymore.

Solution:
Remove m0iscorrupt and core-traces files from source tree

Signed-off-by: Prasanna Kulkarni <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Status: Waiting to be merged PR is waiting for a gatekeeper to merge it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants