setting async_disconnecting flag to avoid multiple async rpc disconn #2004

huanghua78 · 2022-07-21T10:23:32Z

async_disconnecting is used to check if waiting is needed.
No need to call session_put() in rm_remote_free().
Because at this moment, maybe some other requests are still in progress.

Signed-off-by: Hua Huang [email protected]

Problem Statement

While doing Motr shutdown, there might be panic like this:

=== pids of services: 2106389 2106891 2106965 2107036 2107045 2107047 2107058 ===
Shutting down services one by one. mdservice is the last.
----- 2106389 stopping--------lt-m0d: got signal 1
motr[2106389]:  3680  FATAL  [lib/assert.c:50:m0_panic]  panic: (!m0_clink_is_armed(&revc->rcf_disc_wait)) at m0_rpc_service_reverse_session_put() (rpc/service.c:241)  [git: 2.0.0-902-19-gec6209504] /var/motr/root/sandbox.st-73motr-io-small-disks/confd/m0trace.2106389.2022-08-22-13:38:12
Motr panic: (!m0_clink_is_armed(&revc->rcf_disc_wait)) at m0_rpc_service_reverse_session_put() rpc/service.c:241 (errno: 4) (last failed: none) [git: 2.0.0-902-19-gec6209504] pid: 2106389  /var/motr/root/sandbox.st-73motr-io-small-disks/confd/m0trace.2106389.2022-08-22-13:38:12
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_arch_backtrace+0x20)[0x7f1bfb529b20]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_arch_panic+0xdf)[0x7f1bfb529ccf]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_panic+0x127)[0x7f1bfb5179d7]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(+0x46152e)[0x7f1bfb5b752e]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_rpc_service_reverse_sessions_cleanup+0x9f)[0x7f1bfb5b75cf]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(+0x4616ec)[0x7f1bfb5b76ec]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_reqh_service_prepare_to_stop+0xc6)[0x7f1bfb593006]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_reqh_services_prepare_to_stop+0x6e)[0x7f1bfb59183e]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_reqh_shutdown_wait+0x11)[0x7f1bfb591931]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(+0x3e1fce)[0x7f1bfb537fce]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_module_fini+0x70)[0x7f1bfb56aee0]
/home/520428/work/cortx-motr/motr/.libs/libmotr.so.2(m0_cs_fini+0x2d)[0x7f1bfb53bdfd]
/home/520428/work/cortx-motr/motr/.libs/lt-m0d[0x4011cc]
/lib64/libc.so.6(__libc_start_main+0xf3)[0x7f1bf93e54a3]
/home/520428/work/cortx-motr/motr/.libs/lt-m0d[0x40145e]
Motr pid 2106389 waits for debugger.

The problem is that the reverse session connection has been already destroyed and freed.

Design

There are two fixes in this patch.

No need to call session_put() in rm_remote_free().
Because at this moment, maybe some other RM requests are still in progress. The reverse connection will be destroyed in
m0_rpc_service_reverse_sessions_cleanup() while doing system finalization.
Adding a flag rlk_async_disconnecting in the rpc_link. This will avoid making duplicated calls if a
m0_rpc_service_reverse_session_put() is already in progress. And this flag is also used to check if a wait is needed.

Coding

Checklist for Author

Coding conventions are followed and code is consistent

Testing

Checklist for Author

Unit and System Tests are added
Test Cases cover Happy Path, Non-Happy Path and Scalability
Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

Interface change (if any) are documented
Side effects on other features (deployment/upgrade)
Dependencies on other component(s)

Review Checklist

Checklist for Author

JIRA number/GitHub Issue added to PR
PR is self reviewed
Jira and state/status is updated and JIRA is updated with PR link
Check if the description is clear and explained

Documentation

Checklist for Author

Changes done to WIKI / Confluence page / Quick Start Guide

rkothiya · 2022-07-21T16:43:29Z

Jenkins CI Result : Motr#1520

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	41	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/48motr-raid0-io 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	75	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

rkothiya · 2022-07-27T16:19:02Z

Jenkins CI Result : Motr#1535

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	41	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/48motr-raid0-io 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	75	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

huanghua78 · 2022-07-28T05:18:54Z

The 'rm-rcredits-ut', full UT, and ST 61,67 have passed more than 20 iterations.
The isc-service-ut has passed more then 100 iterations.

cortx-admin · 2022-07-28T05:31:16Z

Can one of the admins verify this patch?

huanghua78 · 2022-07-28T07:57:28Z

retest this please

huanghua78 · 2022-08-09T16:27:27Z

retest this please

stale · 2022-08-14T04:50:19Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

rkothiya · 2022-08-16T07:54:42Z

Jenkins CI Result : Motr#1588

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	41	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/48motr-raid0-io 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	75	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

rkothiya · 2022-08-17T15:46:21Z

Jenkins CI Result : Motr#1600

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	42	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/73motr-io-small-disks 04motr-single-node/48motr-raid0-io 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	76	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

yatin-mahajan

Looks good to me.

* async_disconnecting is used to check if waiting is needed. * No need to call session_put() in rm_remote_free(). Because at this moment, maybe some other requests are still in progress. Signed-off-by: Hua Huang <[email protected]>

rkothiya · 2022-08-21T07:47:29Z

Jenkins CI Result : Motr#1613

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	43	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/73motr-io-small-disks 04motr-single-node/48motr-raid0-io 04motr-single-node/74motr-di-corruption-detection 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	77	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

…eagate#2004) * async_disconnecting is used to check if waiting is needed. * No need to call session_put() in rm_remote_free(). Because at this moment, maybe some other requests are still in progress. Signed-off-by: Hua Huang <[email protected]>

huanghua78 requested review from andriytk, ivan-alekhin, madhavemuri, mehjoshi, nikitadanilov, nkommuri, rkothiya, sergey-shilov, sg-shankar, shashank-parulekar, siningwuseagate, vidyadhar-pinglikar, yatin-mahajan and yeshpal-jain-seagate as code owners July 21, 2022 10:23

cla-bot bot added the cla-signed label Jul 21, 2022

auto-assign bot assigned madhavemuri, mehjoshi and nikitadanilov Jul 21, 2022

madhavemuri approved these changes Jul 21, 2022

View reviewed changes

huanghua78 force-pushed the reverse_session_put branch from e7fa93c to c9a32b0 Compare July 27, 2022 10:25

huanghua78 force-pushed the reverse_session_put branch from c9a32b0 to 75058ee Compare August 8, 2022 04:18

hessio added the Status: Waiting to be Reviewed PR is waiting for reviewers to review the PR label Aug 9, 2022

huanghua78 force-pushed the reverse_session_put branch from 75058ee to 251945d Compare August 10, 2022 04:32

stale bot added the needs-attention label Aug 14, 2022

huanghua78 force-pushed the reverse_session_put branch from 251945d to b5f0a0a Compare August 15, 2022 16:12

stale bot removed the needs-attention label Aug 16, 2022

huanghua78 force-pushed the reverse_session_put branch from b5f0a0a to 803340b Compare August 17, 2022 02:08

yatin-mahajan approved these changes Aug 18, 2022

View reviewed changes

huanghua78 removed the Status: Waiting to be Reviewed PR is waiting for reviewers to review the PR label Aug 21, 2022

huanghua78 force-pushed the reverse_session_put branch from 803340b to ec62095 Compare August 21, 2022 01:02

Merge branch 'main' into reverse_session_put

743d578

rkothiya merged commit 5f3ee0d into Seagate:main Aug 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

setting async_disconnecting flag to avoid multiple async rpc disconn #2004

setting async_disconnecting flag to avoid multiple async rpc disconn #2004

Uh oh!

huanghua78 commented Jul 21, 2022 •

edited

Loading

Uh oh!

rkothiya commented Jul 21, 2022

Uh oh!

rkothiya commented Jul 27, 2022

Uh oh!

huanghua78 commented Jul 28, 2022

Uh oh!

cortx-admin commented Jul 28, 2022

Uh oh!

huanghua78 commented Jul 28, 2022

Uh oh!

huanghua78 commented Aug 9, 2022

Uh oh!

stale bot commented Aug 14, 2022

Uh oh!

rkothiya commented Aug 16, 2022

Uh oh!

rkothiya commented Aug 17, 2022

Uh oh!

yatin-mahajan left a comment

Uh oh!

rkothiya commented Aug 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

setting async_disconnecting flag to avoid multiple async rpc disconn #2004

setting async_disconnecting flag to avoid multiple async rpc disconn #2004

Uh oh!

Conversation

huanghua78 commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Design

Coding

Testing

Impact Analysis

Review Checklist

Documentation

Uh oh!

rkothiya commented Jul 21, 2022

Jenkins CI Result : Motr#1520

Motr Test Summary

CppCheck Summary

Uh oh!

rkothiya commented Jul 27, 2022

Jenkins CI Result : Motr#1535

Motr Test Summary

CppCheck Summary

Uh oh!

huanghua78 commented Jul 28, 2022

Uh oh!

cortx-admin commented Jul 28, 2022

Uh oh!

huanghua78 commented Jul 28, 2022

Uh oh!

huanghua78 commented Aug 9, 2022

Uh oh!

stale bot commented Aug 14, 2022

Uh oh!

rkothiya commented Aug 16, 2022

Jenkins CI Result : Motr#1588

Motr Test Summary

CppCheck Summary

Uh oh!

rkothiya commented Aug 17, 2022

Jenkins CI Result : Motr#1600

Motr Test Summary

CppCheck Summary

Uh oh!

yatin-mahajan left a comment

Choose a reason for hiding this comment

Uh oh!

rkothiya commented Aug 21, 2022

Jenkins CI Result : Motr#1613

Motr Test Summary

CppCheck Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

huanghua78 commented Jul 21, 2022 •

edited

Loading