CORTX-30751: Codacy code cleanup (#1606) #1899
Conversation
alfhad
requested review from
andriytk,
huanghua78,
ivan-alekhin,
madhavemuri,
mehjoshi,
nikitadanilov,
nkommuri,
rkothiya,
sergey-shilov,
sg-shankar,
shashank-parulekar,
siningwuseagate,
vidyadhar-pinglikar and
yeshpal-jain-seagate
as code owners
|
Can one of the admins verify this patch? |
huanghua78
left a comment
huanghua78
left a comment
There was a problem hiding this comment.
Please verify this patch manually and inspect the result.
This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <[email protected]>
|
@huanghua78 how to I run/test m0d-device-detach-test.sh |
|
This issue/pull request has been marked as |
hessio
added
the
Status: Changes requested
|
This issue/pull request has been marked as |
huanghua78
left a comment
huanghua78
left a comment
There was a problem hiding this comment.
This test is no longer needed. No manual testing is needed for this patch.
The fix seems good to me.
Jenkins CI Result : Motr#1602Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
ok to test |
This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Alfhad <[email protected]> Signed-off-by: Rinku Kothiya <[email protected]>
6 participants
This patch fixes some of the codacy warnings.
warning fixed : "Double quote to prevent globing and words splitting".
Signed-off-by: alfhad [email protected]
Problem Statement
We see 1688 occurrence of pattern, "Double quote to prevent globing and words splitting".
Design
We are putting the variable references in double quotes.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author