CORTX-32194 : DI generation in motr for data and parity #1875
Conversation
DI checking in io_bottom_half enabled Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
" -G, --DI-generate Flag to generate Data Integrity\n" " -I, --DI-user-input Flag to pass checksum by user\n" Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
1. Reducing size of checksum from 128bytes to 28 bytes, when motr generates checksum. 2. Optimized md5 computation Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
ST 42motr-utils passing Signed-off-by: Rajat Patil <[email protected]>
…ed from server Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
- Added code to populate global offset in index vector for a target - In target FOP prepare use global offset to locate PGIndex and UnitIndex - Write: Compute checksum for those units - Read: Validate checksum for those units Signed-off-by: Rajat Patil <[email protected]>
- Add DU only when space is available - In case of FOP split this will help to split DUs Code cleanup and adding comments Signed-off-by: Rajat Patil <[email protected]>
… for RMW test.
The part of RMW code which modifies existing object is
echo "m0cp update"
$motr_st_util_dir/m0cp -G $MOTR_PARAMS -o $object_id $update_file \
-s $block_size -c $update_count -L $LID \
-u -O $update_offset|| {
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
-42motr-utils -45motr-rmw Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
Signed-off-by: Rajat Patil <[email protected]>
|
retest this please |
|
Thanks for your contribution! |
|
As shown below Rocky linux and DTM-intergration pre-merge jobs have passed, but since the branch needs an update again updating it now and retriggering the pre-merge. |
|
Thanks for your contribution! |
|
Since CI/CD results are from stale code, that is before Rajat had rebased, I have fired the following CI/CD test again : |
Jenkins CI Result : Motr#1595Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
Thanks for your contribution! |
Signed-off-by: Rajat Patil <[email protected]>
|
Thanks for your contribution! |
Signed-off-by: Rajat Patil <[email protected]>
|
Thanks for your contribution! |
TODO : N will be reverted to 1 after addressing the code fix in DI checksum computation in read path, for the specific case of N=1, K=2, 2 disc failure degraded read. Signed-off-by: Rajat Patil <[email protected]>
Jenkins CI Result : Motr#1598Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
Thanks for your contribution! |
Jenkins CI Result : Motr#1599Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
Created task to resolve codacy double quote issue https://jts.seagate.com/browse/CORTX-33961 |
|
As per the request I have ignored the codacy warnings for this patch in codacy dash board |
|
Created BUG to fix 43motr-sync-replication ST permanently and revert back temporary fix https://jts.seagate.com/browse/CORTX-33972 |
rajatpatil98
changed the title
Jenkins CI Result : Motr#1601Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
…eagate#1875) DI Support to generate and validate checksum for data and parity at motr level. - This will help to validate the data with minimal SAL layer changes. - In future SAL layer also can generate DI and pass to motr. Updated m0cp and m0cat utility for DI -G : --DI-generate Flag to generate Data Integrity Detailed requirements and design are to be posted later Signed-off-by: Rajat Patil <[email protected]> Co-authored-by: Shankar More <[email protected]>
7 participants
Problem Statement
Design
-G : --DI-generate Flag to generate Data Integrity
-I : --DI-user-input Flag to pass checksum by user
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author