Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@rohitkolapkar
Copy link
Contributor

Pull Request

Problem Statement

CORTX-30330: Resource Quota Update
CORTX-30331: active users quota
CORTX-30332: POC for operations quota
CORTX-32714: resource limits amendments

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Alexander Voronov and others added 13 commits May 17, 2022 14:17
* CORTX-30331: implement the session manager that maintains quota

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30331: refactor the login procedure

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30331: integrate the session manager with active users quota

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30331: debug the solution

Signed-off-by: Alexander Voronov <[email protected]>
* CORTX-30332: POC for operations quota

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30332: update throttler middleware from POC to production

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30332: set CSM request quota at Configure phase

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30332: add sessions quota

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30332: reserve some memory for CSM future needs

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-30332: resolve PR comments

Signed-off-by: Alexander Voronov <[email protected]>
Signed-off-by: Pawan Kumar Srivastava <[email protected]>
* Modification for one session per user

Signed-off-by: abhijit1patil <[email protected]>

* Updated session expiry time and updated the req calulation formulae

Signed-off-by: abhijit1patil <[email protected]>

* Await update method

Signed-off-by: abhijit1patil <[email protected]>

* logs updated

Signed-off-by: abhijit1patil <[email protected]>
* CORTX-32714: make active users quota configurable

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-32714: allow 'infinite' value for maximum number of users limit

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-32714: remove redundant sessions quota checks

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-32714: fix error description for active users quota

Signed-off-by: Alexander Voronov <[email protected]>

* CORTX-32714: make active users quota infinite by default

Signed-off-by: Alexander Voronov <[email protected]>
…ents (#876)

* Handled exception in throttler middleware and added comments

Signed-off-by: abhijit1patil <[email protected]>

* Codacy Issue handled

Signed-off-by: abhijit1patil <[email protected]>
Signed-off-by: Alexander Voronov <[email protected]>

Co-authored-by: Alexander Voronov <[email protected]>
…F_40B_Resource_Limits

Conflicts:
	csm/core/agent/api.py
	csm/core/services/sessions.py
* Fixing user service initialisation

Signed-off-by: Rohit Kolapkar <[email protected]>

* User management test cases updated

Signed-off-by: Rohit Kolapkar <[email protected]>
@cla-bot
Copy link

cla-bot bot commented Aug 3, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alexander Voronov.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@kupranay kupranay merged commit 76555d1 into main Aug 4, 2022
@rohitkolapkar rohitkolapkar deleted the F_40B_Resource_Limits branch August 8, 2022 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants